Skip to content

Comments

Added Missing Bank ID#1430

Merged
gmason0 merged 1 commit intochsami:developmentfrom
Sunny-P:Rs2Bank.bankIds_missing_Burgh_De_Rott_id
Aug 25, 2025
Merged

Added Missing Bank ID#1430
gmason0 merged 1 commit intochsami:developmentfrom
Sunny-P:Rs2Bank.bankIds_missing_Burgh_De_Rott_id

Conversation

@Sunny-P
Copy link
Contributor

@Sunny-P Sunny-P commented Aug 25, 2025

Added ID 12759 for missing Burgh De Rott bank ID. Variable from 12798 due to quests.
Maintained list formatting.

Summary by CodeRabbit

  • New Features
    • Expanded support for additional bank objects and locations across the game world, improving compatibility with more areas.
  • Bug Fixes
    • Resolved cases where certain banks were not detected or interactable, reducing failures when opening banks.
  • Chores
    • Updated internal bank identifier list to ensure broader coverage and more reliable banking behavior for users.

… due to quests.

Maintained list formatting.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 25, 2025

Walkthrough

Expanded the Integer array of bank IDs in Rs2BankID.java by appending many additional IDs. No changes to methods, control flow, or public API; only the data initializer list for bankIds was extended.

Changes

Cohort / File(s) Summary
Bank ID data expansion
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/gameobject/Rs2BankID.java
Extended public static Integer[] bankIds with numerous additional bank object IDs; existing IDs retained. No logic or signature changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/gameobject/Rs2BankID.java (2)

4-5: Optional: expose an unmodifiable Set view for O(1) membership checks

If callers predominantly perform membership lookups, consider adding a derived Set while keeping the existing public array intact (no API break). This avoids repeated linear scans and boxing pitfalls elsewhere.

Example (outside this diff):

import java.util.Arrays;
import java.util.Collections;
import java.util.HashSet;
import java.util.Set;

public static final Set<Integer> BANK_IDS =
    Collections.unmodifiableSet(new HashSet<>(Arrays.asList(bankIds)));

Callers can then use BANK_IDS.contains(id). Keep bankIds as-is for backward compatibility.


12-14: Nit: optional inline context for the new ID

Consider a small inline comment to document why 12759 was added (e.g., “Burgh de Rott”), aiding future maintainers who scan this long list.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a91cba4 and 874af36.

📒 Files selected for processing (1)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/gameobject/Rs2BankID.java (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
🔇 Additional comments (2)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/gameobject/Rs2BankID.java (2)

12-14: Good addition: 12759 inserted in sorted order and formatting preserved

  • 12759 is correctly placed between 12736 and 12768, maintaining the ascending sequence.
  • No immediate duplicates around the insertion point; list style remains consistent.

12-14: bankIds initializer sanity checks passed
Confirmed that the array contains 12759, has no duplicate entries, and remains fully sorted—no changes needed.

@gmason0 gmason0 merged commit 0f3ba47 into chsami:development Aug 25, 2025
2 checks passed
@Sunny-P Sunny-P deleted the Rs2Bank.bankIds_missing_Burgh_De_Rott_id branch August 27, 2025 10:36
@gmason0 gmason0 mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants