Merged
Conversation
…deposit boxes and GIM group storage (#18929)
… due to quests. Maintained list formatting.
…he microbot plugin manager will load plugins indivually
Remove syncPlugins method from MicrobotPluginManager
…e_Rott_id Added Missing Bank ID
lost enum SLAYER_TASK_CREATURE 693 lost enum SLAYER_TASK_LOCATION 4064 lost enum SLAYER_TASK 5008
This reverts commit 54b2c7c.
[ci skip]
Bump to 1.11.15-SNAPSHOT & Fix Bank Menu Entry Identifiers
Remove Plugins Migrated to Plugin Hub
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughBroad update introducing Slayer data migration from enums to DB tables, numerous API ID additions/removals, UI InterfaceID restructuring, menu/bank action index realignments, Microbot feature removals (NMZ, Jad, Tithe Farm), minor clue/worldpoint updates, resource/item mappings updates, and parent version bumps across modules. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant P as Player
participant SP as SlayerPlugin
participant C as Client
participant DB as DBTableID (Tables)
Note over SP,C: On task update (non-boss)
P->>SP: Task assignment detected
SP->>C: getDBRowsByValue(DB.SlayerTask.ID, keycol=SlayerTask.COL_ID, value=taskId)
C-->>SP: [rowId] or []
alt row found
SP->>C: getDBTableField(rowId, SlayerTask.COL_NAME_UPPERCASE)
C-->>SP: taskName
SP->>C: getDBTableField(rowId, SlayerTask.COL_REGIONS / area id)
C-->>SP: areaId
SP->>C: getDBRowsByValue(DB.SlayerArea.ID, keycol=SlayerArea.COL_AREA_ID, value=areaId)
C-->>SP: [areaRow]
SP->>C: getDBTableField(areaRow, SlayerArea.COL_AREA_NAME_IN_HELPER)
C-->>SP: areaName
SP-->>P: Display taskName and areaName
else no row
SP-->>P: Abort update (no data)
end
Note over SP,C: Boss task path
SP->>C: getDBRowsByValue(DB.SlayerTaskSublist.ID, keycol=SlayerTaskSublist.COL_SUBTABLE_ID, value=subtableId)
C-->>SP: [subRows]
SP->>C: getDBTableField(matchingRow, SlayerTaskSublist.COL_TASK)
C-->>SP: taskRowId
SP->>C: getDBTableField(taskRowId, SlayerTask.COL_NAME_UPPERCASE)
C-->>SP: taskName
SP-->>P: Display boss taskName
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.38.6)runelite-api/src/main/java/net/runelite/api/ItemID.javarunelite-api/src/main/java/net/runelite/api/gameval/AnimationID.javarunelite-api/src/main/java/net/runelite/api/NpcID.java
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Bug Fixes
Chores
Commits
Summary by CodeRabbit
New Features
Changes
Bug Fixes
Removals
Chores