2.0.60 by chsami · Pull Request #1628 · chsami/Microbot

chsami · 2025-12-18T19:09:55Z

No description provided.

These projectiles have source level 1, despite being main-world projectiles, and would be hidden otherwise with roof removal on

This reverts commit e7ae65b.

These projectiles have source level 1, despite being main-world projectiles, and would be hidden otherwise with roof removal on

This happens rarely if the map load is slow and also there are back to back map build packets. Reproduce via sleep(2000) in loadScene() and use Book of the dead to teleport to Hosidius and run to the ladder south.

# Conflicts: # runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsOverlay.java

coderabbitai · 2025-12-18T19:10:19Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR extends the RuneLite API with new game-world constants across multiple ID classes, including item, object, interface, sprite, and varbit identifiers. It reindexes existing SailingBoatFacilityStats constants to insert a new crystal helm resistance property and introduces a new PatchyData database table. The PR also updates item variation mappings, refines GPU rendering logic with improved plane capping and buffer handling, enhances tile iteration in dev tools overlays, and expands world view-based rendering support. Dependencies are updated, including microbot version bump and Linux ARM64 LWJGL native support.

Possibly related PRs

Bump to 1.11.15-SNAPSHOT & Fix Bank Menu Entry Identifiers #1433: Modifies the same generated ID files and item_variations.json by adding and reindexing public constants and variation entries
2.0.38 #1595: Makes overlapping changes to generated game value constants including ItemID, ObjectID variants, and interface IDs
1.9.9.1 #1435: Updates the same gameval ID classes and item_variations.json with new and renamed game-world constants

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title '2.0.60' references a version number but does not describe the actual changes in the pull request, which include API updates, new game constants, dependency upgrades, and bug fixes.	Use a descriptive title that summarizes the main changes, such as 'Update to version 2.0.60 with API additions and dependency updates' or similar.
Description check	⚠️ Warning	No pull request description was provided by the author, making it impossible to understand the intent or scope of the changes.	Add a meaningful description explaining what was changed, why, and any relevant context or migration notes for reviewers.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

runelite-client/src/main/java/net/runelite/client/plugins/devtools/SceneOverlay.java (1)
406-426: Inconsistent loop control: return should be continue

The for-each loop iterates over all actors in the set, but return statements will exit the entire method on the first null check failure. This means if the first actor has no interaction target (or fails canvas projection), all subsequent actors are skipped.
🔎 Apply this diff to fix the loop control flow:
 		Actor ta = fa.getInteracting();
 		if (ta == null)
 		{
-			return;
+			continue;
 		}

 		LocalPoint fl = fa.getLocalLocation();
 		Point fs = Perspective.localToCanvas(client, fl, client.getPlane(), fa.getLogicalHeight() / 2);
 		if (fs == null)
 		{
-			return;
+			continue;
 		}
 		int fsx = fs.getX();
 		int fsy = fs.getY() - INTERACTING_SHIFT;

 		LocalPoint tl = ta.getLocalLocation();
 		Point ts = Perspective.localToCanvas(client, tl, client.getPlane(), ta.getLogicalHeight() / 2);
 		if (ts == null)
 		{
-			return;
+			continue;
 		}

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ed7386 and b024396.

📒 Files selected for processing (17)

runelite-api/src/main/java/net/runelite/api/ItemID.java (3 hunks)
runelite-api/src/main/java/net/runelite/api/NullObjectID.java (1 hunks)
runelite-api/src/main/java/net/runelite/api/ObjectID.java (1 hunks)
runelite-api/src/main/java/net/runelite/api/gameval/DBTableID.java (2 hunks)
runelite-api/src/main/java/net/runelite/api/gameval/InterfaceID.java (3 hunks)
runelite-api/src/main/java/net/runelite/api/gameval/ItemID.java (3 hunks)
runelite-api/src/main/java/net/runelite/api/gameval/ObjectID1.java (1 hunks)
runelite-api/src/main/java/net/runelite/api/gameval/SpriteID.java (1 hunks)
runelite-api/src/main/java/net/runelite/api/gameval/VarPlayerID.java (1 hunks)
runelite-api/src/main/java/net/runelite/api/gameval/VarbitID.java (2 hunks)
runelite-client/pom.xml (4 hunks)
runelite-client/src/main/java/net/runelite/client/callback/Hooks.java (2 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsOverlay.java (2 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/devtools/SceneOverlay.java (3 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/gpu/GpuPlugin.java (4 hunks)
runelite-client/src/main/java/net/runelite/client/plugins/idlenotifier/IdleNotifierPlugin.java (1 hunks)
runelite-client/src/main/resources/item_variations.json (22 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.java

📄 CodeRabbit inference engine (AGENTS.md)

**/*.java: Keep indentation with tabs, follow the brace placement already in MicrobotPlugin.java, and prefer lines under 120 characters
Use UpperCamelCase for types, lowerCamelCase for members, and prefix configuration interfaces with the plugin name (e.g., ExampleConfig)
Rely on Lombok for boilerplate where already adopted

Files:

runelite-api/src/main/java/net/runelite/api/ItemID.java
runelite-api/src/main/java/net/runelite/api/gameval/VarbitID.java
runelite-client/src/main/java/net/runelite/client/callback/Hooks.java
runelite-api/src/main/java/net/runelite/api/ObjectID.java
runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsOverlay.java
runelite-api/src/main/java/net/runelite/api/gameval/VarPlayerID.java
runelite-api/src/main/java/net/runelite/api/NullObjectID.java
runelite-client/src/main/java/net/runelite/client/plugins/devtools/SceneOverlay.java
runelite-api/src/main/java/net/runelite/api/gameval/InterfaceID.java
runelite-client/src/main/java/net/runelite/client/plugins/idlenotifier/IdleNotifierPlugin.java
runelite-api/src/main/java/net/runelite/api/gameval/SpriteID.java
runelite-api/src/main/java/net/runelite/api/gameval/ObjectID1.java
runelite-client/src/main/java/net/runelite/client/plugins/gpu/GpuPlugin.java
runelite-api/src/main/java/net/runelite/api/gameval/DBTableID.java
runelite-api/src/main/java/net/runelite/api/gameval/ItemID.java

🧠 Learnings (13)

📓 Common learnings

Learnt from: Voxsylvae
Repo: chsami/Microbot PR: 1415
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/MicroAgilityPrePostScheduleRequirements.java:7-7
Timestamp: 2025-08-25T06:45:09.673Z
Learning: Always use game ID classes from net.runelite.api.gameval package (like ItemID, ObjectID, NpcID) instead of the deprecated classes in net.runelite.api package. The gameval package contains the new, preferred classes while the old ones in the direct api package are deprecated.

Learnt from: runsonmypc
Repo: chsami/Microbot PR: 1417
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/AgilityScript.java:13-13
Timestamp: 2025-08-25T15:51:39.272Z
Learning: Both net.runelite.api.ItemID and net.runelite.api.gameval.ItemID are valid import paths in the RuneLite codebase. The microbot plugins consistently use net.runelite.api.ItemID as their established pattern.

Learnt from: Voxsylvae
Repo: chsami/Microbot PR: 1415
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/MicroAgilityPrePostScheduleRequirements.java:218-226
Timestamp: 2025-08-25T06:50:43.493Z
Learning: In MicroAgilityPrePostScheduleRequirements.java, the deprecated ItemID constants NATURERUNE and FIRERUNE should be replaced with NATURE_RUNE and FIRE_RUNE respectively when using the gameval package ItemID class.

Learnt from: runsonmypc
Repo: chsami/Microbot PR: 1417
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/AgilityScript.java:284-291
Timestamp: 2025-08-25T15:51:52.157Z
Learning: In RuneLite's ItemID class, both PIEDISH and PIE_DISH constants exist and are valid, both referring to item ID 2313. The gameval package uses PIEDISH while the regular api package uses PIE_DISH, so either naming convention can be used.

📚 Learning: 2025-08-25T06:50:43.493Z

Learnt from: Voxsylvae
Repo: chsami/Microbot PR: 1415
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/MicroAgilityPrePostScheduleRequirements.java:218-226
Timestamp: 2025-08-25T06:50:43.493Z
Learning: In MicroAgilityPrePostScheduleRequirements.java, the deprecated ItemID constants NATURERUNE and FIRERUNE should be replaced with NATURE_RUNE and FIRE_RUNE respectively when using the gameval package ItemID class.

Applied to files:

runelite-api/src/main/java/net/runelite/api/ItemID.java
runelite-api/src/main/java/net/runelite/api/gameval/VarbitID.java
runelite-api/src/main/java/net/runelite/api/ObjectID.java
runelite-api/src/main/java/net/runelite/api/gameval/InterfaceID.java
runelite-api/src/main/java/net/runelite/api/gameval/SpriteID.java
runelite-api/src/main/java/net/runelite/api/gameval/ObjectID1.java
runelite-api/src/main/java/net/runelite/api/gameval/DBTableID.java
runelite-api/src/main/java/net/runelite/api/gameval/ItemID.java

📚 Learning: 2025-08-25T15:51:39.272Z

Learnt from: runsonmypc
Repo: chsami/Microbot PR: 1417
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/AgilityScript.java:13-13
Timestamp: 2025-08-25T15:51:39.272Z
Learning: Both net.runelite.api.ItemID and net.runelite.api.gameval.ItemID are valid import paths in the RuneLite codebase. The microbot plugins consistently use net.runelite.api.ItemID as their established pattern.

Applied to files:

runelite-api/src/main/java/net/runelite/api/ItemID.java
runelite-api/src/main/java/net/runelite/api/gameval/ObjectID1.java

📚 Learning: 2025-08-25T15:51:52.157Z

Learnt from: runsonmypc
Repo: chsami/Microbot PR: 1417
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/AgilityScript.java:284-291
Timestamp: 2025-08-25T15:51:52.157Z
Learning: In RuneLite's ItemID class, both PIEDISH and PIE_DISH constants exist and are valid, both referring to item ID 2313. The gameval package uses PIEDISH while the regular api package uses PIE_DISH, so either naming convention can be used.

Applied to files:

runelite-api/src/main/java/net/runelite/api/ItemID.java
runelite-api/src/main/java/net/runelite/api/gameval/ObjectID1.java
runelite-api/src/main/java/net/runelite/api/gameval/ItemID.java

📚 Learning: 2025-08-25T06:45:09.673Z

Learnt from: Voxsylvae
Repo: chsami/Microbot PR: 1415
File: runelite-client/src/main/java/net/runelite/client/plugins/microbot/agility/MicroAgilityPrePostScheduleRequirements.java:7-7
Timestamp: 2025-08-25T06:45:09.673Z
Learning: Always use game ID classes from net.runelite.api.gameval package (like ItemID, ObjectID, NpcID) instead of the deprecated classes in net.runelite.api package. The gameval package contains the new, preferred classes while the old ones in the direct api package are deprecated.

Applied to files:

runelite-api/src/main/java/net/runelite/api/ItemID.java
runelite-api/src/main/java/net/runelite/api/gameval/VarbitID.java
runelite-api/src/main/java/net/runelite/api/ObjectID.java
runelite-api/src/main/java/net/runelite/api/NullObjectID.java
runelite-api/src/main/java/net/runelite/api/gameval/InterfaceID.java
runelite-api/src/main/java/net/runelite/api/gameval/SpriteID.java
runelite-api/src/main/java/net/runelite/api/gameval/ObjectID1.java