Bump to 1.11.15-SNAPSHOT & Fix Bank Menu Entry Identifiers#1433
Merged
gmason0 merged 20 commits intochsami:developmentfrom Aug 27, 2025
Merged
Bump to 1.11.15-SNAPSHOT & Fix Bank Menu Entry Identifiers#1433gmason0 merged 20 commits intochsami:developmentfrom
gmason0 merged 20 commits intochsami:developmentfrom
Conversation
…deposit boxes and GIM group storage (#18929)
lost enum SLAYER_TASK_CREATURE 693 lost enum SLAYER_TASK_LOCATION 4064 lost enum SLAYER_TASK 5008
This reverts commit 54b2c7c.
[ci skip]
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughProject-wide snapshot bump to 1.11.15-SNAPSHOT. Large API/data updates around Slayer: enums removed/replaced with DB tables, new Client API for DB table rows, extensive InterfaceID/Varbit/VarPlayer additions, many ID constants added/renamed. Client plugins updated to use DB-backed Slayer data and new menu identifier semantics; coordinates and resources adjusted. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Player
participant Client
participant SlayerPlugin
participant DB as DBTableID (runtime)
note over SlayerPlugin: Startup
Player->>Client: Login
Client->>SlayerPlugin: startup()
SlayerPlugin->>Client: getDBTableRows(SlayerArea)
SlayerPlugin->>Client: getDBRowsByValue(SlayerArea, COL_AREA_ID, areaId)
Client-->>SlayerPlugin: Row refs
note over SlayerPlugin: Update task
Client->>SlayerPlugin: varbits/vars changed
SlayerPlugin->>Client: read taskId, bossTask flag, areaId
alt Boss task
SlayerPlugin->>Client: getDBRowsByValue(SlayerTaskSublist, COL_SUBTABLE_ID, bossId)
SlayerPlugin->>Client: getDBTableField(SlayerTaskSublist.COL_TASK -> SlayerTask.COL_NAME_UPPERCASE)
else Normal task
SlayerPlugin->>Client: getDBRowsByValue(SlayerTask, COL_ID, taskId)
SlayerPlugin->>Client: getDBTableField(SlayerTask.COL_NAME_UPPERCASE)
end
SlayerPlugin->>Client: getDBRowsByValue(SlayerArea, COL_AREA_ID, areaId)
SlayerPlugin->>Client: getDBTableField(SlayerArea.COL_AREA_NAME_IN_HELPER)
SlayerPlugin-->>Player: Update infobox/name/location
sequenceDiagram
autonumber
actor User
participant UI as UI Widget/Menu
participant MES as MenuEntrySwapper
note over UI: Menu entry created
User->>UI: Right-click action
UI-->>MES: MenuEntry (identifier, op, option, target)
MES->>MES: compute swaps using entry.getIdentifier()
MES-->>UI: Mutated menu order
User->>UI: Click desired option
UI-->>MES: Selected MenuEntry (identifier)
MES->>MES: Compare by identifier, finalize swap logic
UI-->>User: Action executed
sequenceDiagram
autonumber
actor User
participant Layout as Bank LayoutManager
participant Client
note over Layout: Drawing laid-out item
Layout->>Layout: Assign actions at fixed indices 0–10
User->>Client: Click menu index N
alt Potion store path
Client->>Layout: onMenuOptionClicked
Layout->>Client: Set Param1= BANKMAIN.POTIONSTORE_ITEMS, Param0=idx
else Other withdraw/ops
Client->>Client: Handle by fixed index mapping
end
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120+ minutes Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.38.6)runelite-api/src/main/java/net/runelite/api/ItemID.javarunelite-api/src/main/java/net/runelite/api/gameval/DBTableID.javarunelite-api/src/main/java/net/runelite/api/NpcID.java
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (39)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Chore
Summary by CodeRabbit
New Features
Refactor
Bug Fixes
Tests
Chores