Remove syncPlugins method from MicrobotPluginManager

[gmason0]

This method is no longer required considering plugins that are downloaded & installed from the Microbot Plugin Hub are loaded individually.

This resolves the issue where plugins that were from the plugin hub were trying to be loaded using the sideloaded-plugins folder did not show.

Summary by CodeRabbit

• Refactor
  • Standardized plugin registration through a public API, with no expected user-facing change.
• Bug Fixes
  • Adjusted sideloaded external plugin handling: plugins that are no longer installed are no longer automatically removed during sideload operations.
• Chores
  • Removed legacy cleanup step from the sideload flow to streamline external plugin loading.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The plugin registration now uses the public add(plugin) method instead of directly appending to the internal list. In the Microbot external plugin manager, the syncPlugins() method and its invocation from loadSideLoadPlugins() were removed, eliminating the sideload purge step.

Changes

Cohort / File(s)	Summary
Plugin registration path runelite-client/src/main/java/net/runelite/client/plugins/PluginManager.java	Replace direct this.plugins.add(plugin) with add(plugin) after instantiating a plugin. No other logic changes.
Microbot sideload sync removal runelite-client/src/main/java/net/runelite/client/plugins/microbot/externalplugins/MicrobotPluginManager.java	Remove public void syncPlugins() and its call from loadSideLoadPlugins(), so sideload loading no longer performs automatic removal of non-installed external plugins.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant MicrobotPluginManager as MicrobotPluginManager
  participant ExternalPluginLoader as ExternalPluginLoader

  rect rgba(200,230,255,0.3)
  note over MicrobotPluginManager: Previous flow (with sync)
  User->>MicrobotPluginManager: loadSideLoadPlugins()
  MicrobotPluginManager->>MicrobotPluginManager: syncPlugins() [purge not-installed]
  MicrobotPluginManager->>ExternalPluginLoader: Load installed external plugins
  ExternalPluginLoader-->>MicrobotPluginManager: Plugins loaded
  end

  rect rgba(200,255,200,0.3)
  note over MicrobotPluginManager: New flow (sync removed)
  User->>MicrobotPluginManager: loadSideLoadPlugins()
  MicrobotPluginManager->>ExternalPluginLoader: Load installed external plugins
  ExternalPluginLoader-->>MicrobotPluginManager: Plugins loaded
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Adjust Install workflow of MicrobotPluginManager #1423 — Introduced syncPlugins() and invoked it from loadSideLoadPlugins(); this PR removes that method and call, touching the same flow.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a91cba4 and fbc1d01.

📒 Files selected for processing (2)

• runelite-client/src/main/java/net/runelite/client/plugins/PluginManager.java (1 hunks)
• runelite-client/src/main/java/net/runelite/client/plugins/microbot/externalplugins/MicrobotPluginManager.java (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.