Rs2Walker handleFairyRings improvements

[Krulvis]

Reworking some of the logic to not return out of the handle interaction after using 'last-destination' but always make sure that we wait for the player's fairyring graphics to disappear.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change overhauls Rs2Walker’s transport and fairy ring handling. Fairy rings now support last-destination actions, interface configuration, slot rotation via new rotation routines, and arrival detection via graphics/world checks. A broad transport framework is added: route analysis (direct vs banked), transport discovery/preparation for destinations and paths, banking workflows (withdraw then continue), and handlers for ships/boats/minigames/canoes/gliders/POH. New utilities include transport item checks, missing-item computation, teleport-item detection, spell rune requirements, area checks, performance logging, world map closing, and public APIs for reachability and nearest accessible targets.

Possibly related PRs

• Web Walker Fixes #1419: Also modifies Rs2Walker.java, adjusting door/imposter-object filtering; overlaps in the same utility class touched by this PR’s extensive transport and interaction logic.

Pre-merge checks (1 passed, 2 warnings)

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title Check	⚠️ Warning	The title “Rs2Walker handleFairyRings improvements” highlights only the fairy ring logic updates, but the pull request also introduces extensive pathfinding and transport framework enhancements, banking workflows, and new utility methods, so it does not capture the primary scope of changes.	Consider revising the title to reflect both the fairy ring refinements and the broader transport and pathfinding framework additions, for example “Extend Rs2Walker transport framework and refine fairy ring handling.”
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	The description accurately describes the modifications to the fairy ring interaction logic, which is part of the changeset, so it is not off-topic and therefore passes the lenient relevance check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (1)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java (1)

2544-2544: Make the graphic ID a constant.

Minor polish: this is a constant; mark final and use screaming case.

Apply:

-    private static int fairyRingGraphicId = 569;
+    private static final int FAIRY_RING_GRAPHIC_ID = 569;

And update references accordingly.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7c92f8 and c443910.

📒 Files selected for processing (1)

• runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java (5)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/poh/PohTeleports.java (1)

• PohTeleports (34-231)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/gameobject/Rs2GameObject.java (1)

• Rs2GameObject (36-2010)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/equipment/Rs2Equipment.java (1)

• Rs2Equipment (27-485)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/inventory/Rs2Inventory.java (1)

• Rs2Inventory (46-2324)

runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/player/Rs2Player.java (1)

• Rs2Player (67-2076)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Build