Skip to content

Comments

2.0.6#1511

Merged
chsami merged 21 commits intomainfrom
development
Sep 12, 2025
Merged

2.0.6#1511
chsami merged 21 commits intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Sep 12, 2025

POH walker fixes + fishing trawler bug fix

Krulvis and others added 21 commits September 9, 2025 18:47
# Conflicts:
#	runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java
# Conflicts:
#	runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_poh.tsv
Don't add teleports to POH when already in house
fix(FishingTrawler): fix reward looting by checking for visible widget
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates microbot.version to 2.0.6 and makes multiple transport system changes: adds PoH transport integration via new PohTransport, expands Transport constructors and parsing, removes enum-based fields, and adjusts resource loading. PathfinderConfig now merges PoH transports and introduces consumable teleport filtering. Rs2PohCache adds POH fairy ring handling, transport mapping, persistence hooks, and event-based updates. PohTeleports adds getTransportsToPoh and changes portal interaction. HouseStyle renames pohLocation to pohExitWorldPoint and adds getPohExitPoint; HouseLocation updates accordingly. Rs2Walker changes PoH gating, uses PohTransport.execute, and updates getTransportsForPath signatures. FishingTrawlerScript replaces a fixed sleep with a widget visibility wait-and-click. ShortestPathPlugin adds a blank line.

Possibly related PRs

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.38.6)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bfae8b8 and 60b5e6c.

⛔ Files ignored due to path filters (5)
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/fairy_rings.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_items.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_poh.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_portal_poh.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_spells.tsv is excluded by !**/*.tsv
📒 Files selected for processing (12)
  • runelite-client/pom.xml (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/fishing/FishingTrawler/FishingTrawlerScript.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/ShortestPathPlugin.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/Transport.java (3 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/shortestpath/pathfinder/PathfinderConfig.java (5 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/cache/Rs2PohCache.java (5 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/cache/serialization/PohTeleportDataAdapter.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/poh/PohTeleports.java (5 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/poh/PohTransport.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/poh/data/HouseLocation.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/poh/data/HouseStyle.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/walker/Rs2Walker.java (60 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami changed the title 2.0.5 2.0.6 Sep 12, 2025
@chsami chsami merged commit f4cf2c2 into main Sep 12, 2025
2 of 3 checks passed
This was referenced Sep 21, 2025
This was referenced Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants