Construction 2, Rs2GroundItem, and Rs2GrandExchange improvements.#1538
Construction 2, Rs2GroundItem, and Rs2GrandExchange improvements.#1538Gage307 wants to merge 4 commits intochsami:developmentfrom
Conversation
…e butler after a break or for the first loop
…we need both for this script. Minor changes to butler, added enter dungeon to returnToTheHouse if we're building oak dungeon doors
… on the ground if our inventory is full.
…w some time for the widget to load. This is needed because if we have previously searched the item the widget is all ready visible. Causing the script to misclick cyclically.
WalkthroughThe plugin sets Construction2Script.firstRun to true on startup. Construction2Script refactors object targeting by splitting closest-object retrieval into GameObject and TileObject methods, adds objectIDs and firstRun fields, and introduces callTheButler plus a returnToTheHouse(List) path including dungeon door handling. Build/remove logic now supports both GameObject and TileObject flows, with adjusted thresholds and added logging, and expanded Butler dialogue handling. Rs2GrandExchange adds a short sleep after typing the item name during BUY to allow widget loading. Rs2GroundItem’s coreLoot now exits early when the inventory is full before waiting for despawn. Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (4)📚 Learning: 2025-08-25T15:51:39.272ZApplied to files:
📚 Learning: 2025-08-25T06:45:09.673ZApplied to files:
📚 Learning: 2025-09-10T01:10:09.440ZApplied to files:
📚 Learning: 2025-09-10T01:10:09.440ZApplied to files:
🧬 Code graph analysis (3)runelite-client/src/main/java/net/runelite/client/plugins/microbot/GeoffPlugins/construction2/Construction2Plugin.java (1)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/grounditem/Rs2GroundItem.java (1)
runelite-client/src/main/java/net/runelite/client/plugins/microbot/GeoffPlugins/construction2/Construction2Script.java (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (10)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gage307
changed the title
|
the construction2 scripts have been moved to the hub. plese take out these changes and apply them in the hub if you like. Thx |
I'm on it! |
2 participants
Construction 2: Added support for break handler, added support for both tile objects and game objects as both are needed depending on what we're building.
Rs2GroundItem: Fixed a bug that would cause Rev Killer to click loot on the ground over and over despite a full inventory.
Rs2GrandExchange: Fixed a bug that would cause the script to loop buying an item unsuccessfully; if we've previously searched the item within the Grand Exchange.