Skip to content

Construction 2, Rs2GroundItem, and Rs2GrandExchange improvements. #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gage307 wants to merge 4 commits into from
Closed

Construction 2, Rs2GroundItem, and Rs2GrandExchange improvements. #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95a4273
fix(Construction2): Added firstRun so we know if we need to summon th…
Gage307 Aug 31, 2025
5f781ad
fix(Construction2): Added support for tileObjects and gameObjects as …
Gage307 Aug 31, 2025
56b03de
fix(Rs2GroundItem): Prevents Rs2GroundItem from spam clicking an item…
Gage307 Sep 24, 2025
b7f0bdc
fix(Rs2GrandExchange): Added a small randomized sleep. This will allo…
Gage307 Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../net/runelite/client/plugins/microbot/GeoffPlugins/construction2/Construction2Plugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ protected void startUp() throws AWTException {
if (overlayManager != null) {
overlayManager.add(construction2Overlay);
}
Construction2Script.firstRun = true;
construction2Script.run(config);
}

Expand Down
277 changes: 203 additions & 74 deletions .../net/runelite/client/plugins/microbot/GeoffPlugins/construction2/Construction2Script.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import net.runelite.api.*;
import net.runelite.api.coords.WorldPoint;
import net.runelite.api.gameval.InterfaceID;
import net.runelite.api.widgets.Widget;
import net.runelite.client.plugins.microbot.Microbot;
import net.runelite.client.plugins.microbot.Script;
Expand All @@ -16,6 +17,7 @@
import net.runelite.client.plugins.microbot.util.npc.Rs2NpcModel;
import net.runelite.client.plugins.microbot.util.player.Rs2Player;
import net.runelite.client.plugins.microbot.util.tabs.Rs2Tab;
import net.runelite.client.plugins.microbot.util.tile.Rs2Tile;
import net.runelite.client.plugins.microbot.util.walker.Rs2Walker;
import net.runelite.client.plugins.microbot.util.widget.Rs2Widget;

Expand All @@ -35,11 +37,15 @@ public class Construction2Script extends Script {
private static final List<Integer> MAHOGANY_TABLE = List.of(13298, 15298);
private static final List<Integer> MYTHICAL_CAPE_MOUNT = List.of(15394, 31986);

public GameObject getClosestTile(List<Integer> objIDs) {
private static List<Integer> objectIDs = List.of(0);

public static boolean firstRun = false;

public GameObject getClosestTileGameObject(List<Integer> objIDs) {
List<GameObject> objects = Rs2GameObject.getGameObjects();
GameObject closest = null;
WorldPoint playerLocation = Rs2Player.getWorldLocation();

for (GameObject obj : objects) {
if (objIDs.contains(obj.getId())) {
if (closest == null || Rs2Walker.getDistanceBetween(playerLocation, obj.getWorldLocation()) < Rs2Walker.getDistanceBetween(playerLocation, closest.getWorldLocation())) {
Expand All @@ -50,6 +56,21 @@ public GameObject getClosestTile(List<Integer> objIDs) {
return closest;
}

public TileObject getClosestTileTileObject(List<Integer> objIDs) {
List<TileObject> tileObjects = Rs2GameObject.getTileObjects();
TileObject closest = null;
WorldPoint playerLocation = Rs2Player.getWorldLocation();

for (TileObject obj : tileObjects) {
if (objIDs.contains(obj.getId())) {
if (closest == null || Rs2Walker.getDistanceBetween(playerLocation, obj.getWorldLocation()) < Rs2Walker.getDistanceBetween(playerLocation, closest.getWorldLocation())) {
closest = obj;
}
}
}
return closest;
}

public Rs2NpcModel getButler() {
return Rs2Npc.getNpc("Demon butler");
}
Expand Down Expand Up @@ -133,17 +154,21 @@ public void grabPlanksWhileWeBuild(Construction2Config config, int actionDelay){
if(getButler() != null) {
sleepUntil(()-> getButler() != null && getButler().isInteractingWithPlayer(), Rs2Random.between(750,1500));
if(!getButler().isInteractingWithPlayer()){
if (Rs2Inventory.count(config.selectedMode().getPlankItemId()) <= Rs2Random.between(0, 18)) butler(config, actionDelay);
if (Rs2Inventory.count(config.selectedMode().getPlankItemId()) <= Rs2Random.between(10, 18)) butler(config, actionDelay);
} else {
butler(config, actionDelay);
}
} else {
if(firstRun){
callTheButler();
if(getButler() != null) firstRun = false;
}
}
}

private void calculateState(Construction2Config config) {
boolean hasRequiredPlanks;
NPC butler = getButler();
List<Integer> objectIDs = List.of(0);
switch (config.selectedMode()) {
case OAK_DUNGEON_DOOR:
objectIDs = OAK_DUNGEON_DOOR;
Expand All @@ -162,114 +187,202 @@ private void calculateState(Construction2Config config) {
}

if (workingTile == null) {
workingTile = getClosestTile(objectIDs).getWorldLocation();
if(!objectIDs.equals(OAK_DUNGEON_DOOR)){
workingTile = getClosestTileGameObject(objectIDs).getWorldLocation();
} else {
workingTile = getClosestTileTileObject(objectIDs).getWorldLocation();
}
}

GameObject objOnWorkingTile = Rs2GameObject.getGameObject(workingTile);
if (objOnWorkingTile == null || !objectIDs.contains(objOnWorkingTile.getId())) {
// Find new working tile
workingTile = getClosestTile(objectIDs).getWorldLocation();
GameObject objOnWorkingTile = null;
TileObject tileObjOnWorkingTile = null;
if(!objectIDs.equals(OAK_DUNGEON_DOOR)){
objOnWorkingTile = Rs2GameObject.getGameObject(workingTile);
} else {
tileObjOnWorkingTile = Rs2GameObject.getTileObject(workingTile);
}

if (objOnWorkingTile.getId() == objectIDs.get(0)) {
state = Construction2State.Remove;
} else if (objOnWorkingTile.getId() == objectIDs.get(1) && hasRequiredPlanks) {
state = Construction2State.Build;
} else if (objOnWorkingTile.getId() == objectIDs.get(1) && butler != null) {
state = Construction2State.Butler;
} else if (!objectIDs.contains(objOnWorkingTile.getId())) {
state = Construction2State.Idle;
Microbot.getNotifier().notify("Looks like we are no longer in our house.");
returnToTheHouse();
if (objOnWorkingTile == null && tileObjOnWorkingTile == null) {
// Find new working tile
if(!objectIDs.equals(OAK_DUNGEON_DOOR)){
workingTile = getClosestTileGameObject(objectIDs).getWorldLocation();
objOnWorkingTile = Rs2GameObject.getGameObject(workingTile);
} else {
workingTile = getClosestTileTileObject(objectIDs).getWorldLocation();
tileObjOnWorkingTile = Rs2GameObject.getTileObject(workingTile);
}
}

if(!objectIDs.equals(OAK_DUNGEON_DOOR)){
if (objOnWorkingTile.getId() == objectIDs.get(0)) {
state = Construction2State.Remove;
} else if (objOnWorkingTile.getId() == objectIDs.get(1) && hasRequiredPlanks) {
state = Construction2State.Build;
} else if (objOnWorkingTile.getId() == objectIDs.get(1)) {
state = Construction2State.Butler;
} else if (!objectIDs.contains(objOnWorkingTile.getId())) {
state = Construction2State.Idle;
Microbot.getNotifier().notify("Looks like we are no longer in our house.");
returnToTheHouse(objectIDs);
}
} else {
if (tileObjOnWorkingTile.getId() == objectIDs.get(0)) {
state = Construction2State.Remove;
} else if (tileObjOnWorkingTile.getId() == objectIDs.get(1) && hasRequiredPlanks) {
state = Construction2State.Build;
} else if (tileObjOnWorkingTile.getId() == objectIDs.get(1)) {
state = Construction2State.Butler;
} else if (!objectIDs.contains(tileObjOnWorkingTile.getId())) {
state = Construction2State.Idle;
Microbot.getNotifier().notify("Looks like we are no longer in our house.");
returnToTheHouse(objectIDs);
}
}
}

private void returnToTheHouse(){
private void returnToTheHouse(List<Integer> objIDs){
GameObject housePortal = Rs2GameObject.getGameObject("Portal");
firstRun = true; //we're returning from break we'll need to recall the butler
if(housePortal != null){
if(Rs2GameObject.interact(housePortal, "Build mode")){
sleepUntil(()-> Rs2Player.getWorldLocation() != null
&& Rs2Player.getWorldLocation().getRegionX() == 29
&& Rs2Player.getWorldLocation().getRegionY() == 89, Rs2Random.between(10000,20000));
sleep(2000,5000);
}
if(objIDs.equals(OAK_DUNGEON_DOOR)){
// We need to enter the dungeon
if(Rs2GameObject.getGameObject("Dungeon entrance", true) !=null){
if(Rs2GameObject.interact("Dungeon entrance", "Enter", true)){
sleepUntil(()-> Rs2Player.isMoving(), Rs2Random.between(500,1000));
sleepUntil(()-> !Rs2Player.isMoving(), Rs2Random.between(10000,15000));
}
}
}
} else {
Microbot.getNotifier().notify("Can't find the house portal!");
shutdown();
}
}

private void buildSpace(Construction2Config config, int actionDelay) {
GameObject space = Rs2GameObject.getGameObject(workingTile);
int spaceId = space != null ? space.getId() : -1;
char buildKey = '1';

switch (config.selectedMode()) {
case OAK_DUNGEON_DOOR:
buildKey = '1';
break;
case OAK_LARDER:
buildKey = '2';
break;
case MAHOGANY_TABLE:
buildKey = '6';
break;
// case MYTHICAL_CAPE:
// buildKey = '4';
// break;
default:
return;
}
GameObject gameObjSpace = Rs2GameObject.getGameObject(workingTile);
TileObject tileObjSpace = Rs2GameObject.getTileObject(workingTile);
if(!objectIDs.equals(OAK_DUNGEON_DOOR)){
GameObject space = gameObjSpace;
int spaceId = space != null ? space.getId() : -1;
char buildKey = '1';

switch (config.selectedMode()) {
case OAK_DUNGEON_DOOR:
buildKey = '1';
break;
case OAK_LARDER:
buildKey = '2';
break;
case MAHOGANY_TABLE:
buildKey = '6';
break;
// case MYTHICAL_CAPE:
// buildKey = '4';
// break;
default:
return;
}

if (space == null) return;
if (Rs2GameObject.interact(space, "Build")) {
System.out.println("Interacted with build space: " + space.getId());
sleepUntilOnClientThread(this::hasFurnitureInterfaceOpen, 2500);
System.out.println("Pressing key: " + buildKey);
Rs2Keyboard.keyPress(buildKey); // Ensure this is the correct key for the selected build option
sleepUntilOnClientThread(() -> spaceId != space.getId(), 2500);
System.out.println("Built object: " + config.selectedMode());
if (space == null) return;
if (Rs2GameObject.interact(space, "Build")) {
System.out.println("Interacted with build space: " + space.getId());
sleepUntilOnClientThread(this::hasFurnitureInterfaceOpen, 2500);
System.out.println("Pressing key: " + buildKey);
Rs2Keyboard.keyPress(buildKey); // Ensure this is the correct key for the selected build option
sleepUntilOnClientThread(() -> spaceId != space.getId(), 2500);
System.out.println("Built object: " + config.selectedMode());
} else {
System.out.println("Failed to interact with build space: " + space.getId());
}
} else {
System.out.println("Failed to interact with build space: " + space.getId());
TileObject space = tileObjSpace;
int spaceId = space != null ? space.getId() : -1;
char buildKey = '1';

switch (config.selectedMode()) {
case OAK_DUNGEON_DOOR:
buildKey = '1';
break;
case OAK_LARDER:
buildKey = '2';
break;
case MAHOGANY_TABLE:
buildKey = '6';
break;
// case MYTHICAL_CAPE:
// buildKey = '4';
// break;
default:
return;
}

if (space == null) return;
if (Rs2GameObject.interact(space, "Build")) {
System.out.println("Interacted with build space: " + space.getId());
sleepUntilOnClientThread(this::hasFurnitureInterfaceOpen, 2500);
System.out.println("Pressing key: " + buildKey);
Rs2Keyboard.keyPress(buildKey); // Ensure this is the correct key for the selected build option
sleepUntilOnClientThread(() -> spaceId != space.getId(), 2500);
System.out.println("Built object: " + config.selectedMode());
} else {
System.out.println("Failed to interact with build space: " + space.getId());
}
}
}

private void removeSpace(Construction2Config config, int actionDelay) {
GameObject builtObject = Rs2GameObject.getGameObject(workingTile);
int spaceId = builtObject != null ? builtObject.getId() : -1;

if (builtObject == null) return;
if(builtObject.getId() == 15328 || builtObject.getId() == 15403 || builtObject.getId() == 15298 || builtObject.getId() == 31986) return;

if (Rs2GameObject.interact(builtObject, "Remove")) {
System.out.println("Interacted with remove option: " + builtObject.getId());
sleepUntilOnClientThread(() -> hasRemoveInterfaceOpen(config), 2500);
Rs2Keyboard.keyPress('1');
sleepUntilOnClientThread(() -> spaceId != builtObject.getId(), 2500);
System.out.println("Removed object: " + config.selectedMode());
GameObject gameObjSpace = Rs2GameObject.getGameObject(workingTile);
TileObject tileObjSpace = Rs2GameObject.getTileObject(workingTile);

if(!objectIDs.equals(OAK_DUNGEON_DOOR)){
GameObject builtObject = gameObjSpace;
int spaceId = builtObject != null ? builtObject.getId() : -1;

if (builtObject == null) return;
if(builtObject.getId() == 15328 || builtObject.getId() == 15403 || builtObject.getId() == 15298 || builtObject.getId() == 31986) return;

if (Rs2GameObject.interact(builtObject, "Remove")) {
System.out.println("Interacted with remove option: " + builtObject.getId());
sleepUntilOnClientThread(() -> hasRemoveInterfaceOpen(config), 2500);
Rs2Keyboard.keyPress('1');
sleepUntilOnClientThread(() -> spaceId != builtObject.getId(), 2500);
System.out.println("Removed object: " + config.selectedMode());
} else {
System.out.println("Failed to interact with remove option: " + builtObject.getId());
}
} else {
System.out.println("Failed to interact with remove option: " + builtObject.getId());
TileObject builtObject = tileObjSpace;
int spaceId = builtObject != null ? builtObject.getId() : -1;

if (builtObject == null) return;
if(builtObject.getId() == 15328 || builtObject.getId() == 15403 || builtObject.getId() == 15298 || builtObject.getId() == 31986) return;

if (Rs2GameObject.interact(builtObject, "Remove")) {
System.out.println("Interacted with remove option: " + builtObject.getId());
sleepUntilOnClientThread(() -> hasRemoveInterfaceOpen(config), 2500);
Rs2Keyboard.keyPress('1');
sleepUntilOnClientThread(() -> spaceId != builtObject.getId(), 2500);
System.out.println("Removed object: " + config.selectedMode());
} else {
System.out.println("Failed to interact with remove option: " + builtObject.getId());
}
}
}

private void butler(Construction2Config config, int actionDelay) {
var butler = getButler();
if (butler == null) return;
if(butler == null) callTheButler();
boolean butlerIsInteracting = butler.isInteractingWithPlayer();

if (!butlerIsInteracting) {
Rs2Tab.switchTo(InterfaceTab.SETTINGS);

Widget houseOptionWidget = Rs2Widget.getWidget(7602207);
sleepUntil(()-> houseOptionWidget != null, Rs2Random.between(2000,5000));
if (houseOptionWidget != null) Rs2Widget.clickWidget(houseOptionWidget);

Widget callServantWidget = Rs2Widget.getWidget(24248342);
sleepUntil(()-> callServantWidget != null, Rs2Random.between(2000,5000));
if (callServantWidget != null) Rs2Widget.clickWidget(callServantWidget);

sleepUntil(()-> Rs2Dialogue.isInDialogue(), Rs2Random.between(2000,5000));
callTheButler();
}

if (Rs2Dialogue.isInDialogue() || Rs2Npc.interact(butler, "Talk-to")) {
Expand Down Expand Up @@ -300,6 +413,22 @@ private void butler(Construction2Config config, int actionDelay) {
}
}

public void callTheButler(){
Rs2Tab.switchTo(InterfaceTab.SETTINGS);

Widget houseOptionWidget = Rs2Widget.getWidget(7602207);
sleepUntil(()-> houseOptionWidget != null, Rs2Random.between(2000,5000));
if (houseOptionWidget != null) Rs2Widget.clickWidget(houseOptionWidget);

sleep(1000,2000); // allow the client to load the widget

Widget callServantWidget = Rs2Widget.getWidget(370,22);
sleepUntil(()-> callServantWidget != null, Rs2Random.between(2000,5000));
if (callServantWidget != null) Rs2Widget.clickWidget(callServantWidget);

sleepUntil(()-> Rs2Dialogue.isInDialogue(), Rs2Random.between(2000,5000));
}

private boolean hasRemoveInterfaceOpen(Construction2Config config) {
switch (config.selectedMode()) {
case OAK_DUNGEON_DOOR:
Expand Down
2 changes: 2 additions & 0 deletions ...c/main/java/net/runelite/client/plugins/microbot/util/grandexchange/Rs2GrandExchange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,8 @@ public static boolean processOffer(GrandExchangeRequest request) {
}
Rs2Keyboard.typeString(request.getItemName());

sleep(500,800); //allow the widget to load

if (!Rs2Widget.sleepUntilHasWidgetText(searchName, 162, 43, false, 5000)) break;

sleepUntil(() -> getSearchResultWidget(request.getItemName(), request.isExact()) != null, 2200);
Expand Down
Loading