Skip to content

Comments

2.0.19#1553

Merged
chsami merged 3 commits intomainfrom
development
Oct 5, 2025
Merged

2.0.19#1553
chsami merged 3 commits intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Oct 5, 2025

no more crashes for incompatible plugins

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

  • Updated runelite-client/pom.xml property microbot.version from 2.0.18.1 to 2.0.19.
  • Adjusted whitespace in MicrobotPluginClassLoader (private final ClassLoader parent;), no functional change.
  • In MicrobotPluginManager, added catch(Throwable) in sideload plugin loading paths to handle errors during sideloading and class loading, logging "Incompatible plugin found: [name]" and continuing execution.

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5c70ae and 3e1a098.

📒 Files selected for processing (3)
  • runelite-client/pom.xml (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/externalplugins/MicrobotPluginClassLoader.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/microbot/externalplugins/MicrobotPluginManager.java (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit 1ef8258 into main Oct 5, 2025
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant