Skip to content

2.0.19 #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsami merged 3 commits into from
Oct 5, 2025
Merged

2.0.19 #1553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7090f66
fix: avoid crashing when incompatible plugin is loaded
chsami Oct 5, 2025
249f105
fix: avoid crashing when incompatible plugin is loaded
chsami Oct 5, 2025
3e1a098
chore: cleanup
chsami Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runelite-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<git.commit.id.abbrev>nogit</git.commit.id.abbrev>
<git.dirty>false</git.dirty>
<shade.skip>false</shade.skip>
<microbot.version>2.0.18.1</microbot.version>
<microbot.version>2.0.19</microbot.version>
<microbot.commit.sha>nogit</microbot.commit.sha>
</properties>

Expand Down
2 changes: 1 addition & 1 deletion .../java/net/runelite/client/plugins/microbot/externalplugins/MicrobotPluginClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class MicrobotPluginClassLoader extends URLClassLoader implements Reflect
@Setter
private MethodHandles.Lookup lookup;

private final ClassLoader parent;
private final ClassLoader parent;

public MicrobotPluginClassLoader(File jarFile, ClassLoader parent) throws IOException {
super(new URL[]{jarFile.toURI().toURL()}, null);
Expand Down
4 changes: 4 additions & 0 deletions ...main/java/net/runelite/client/plugins/microbot/externalplugins/MicrobotPluginManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,8 @@ private void loadSideLoadPlugin(String internalName) {
plugins.add(clazz);
} catch (ClassNotFoundException e) {
log.trace("Class not found during sideloading: {}", classInfo.getName(), e);
} catch(Throwable t) {
log.error("Incompatible plugin found: " + internalName);
}
}
loadPlugins(plugins, null);
Expand Down Expand Up @@ -831,6 +833,8 @@ private void refresh() {
pluginClasses.add(clazz);
} catch (ClassNotFoundException e) {
log.trace("Class not found during plugin loading: {}", classInfo.getName(), e);
} catch(Throwable t) {
log.error("Incompatible plugin found: " + pluginName);
}
}

Expand Down