Merged
Conversation
Jagex recently updated their hiscore backend, which now exhibits different behavior for players with unranked skills and activities. Specifically, they now return the real levels (and xp for skills) even when unranked. Without this change, bosses with 0 kills and minigames which have no score display `0` instead of the expected `--`; this change preserves the expected old behavior for those entries, while still displaying real kill counts and activity scores when they are above 0, whether the score is high enough to be ranked or not.
[ci skip]
# Conflicts: # cache/pom.xml # pom.xml # runelite-api/pom.xml # runelite-client/pom.xml # runelite-jshell/pom.xml # runelite-maven-plugin/pom.xml
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates the RuneLite parent POM version from 1.12.4 to 1.12.5 across multiple modules (cache, runelite-api, runelite-client, runelite-jshell, runelite-maven-plugin). It also bumps the microbot version from 2.0.41 to 2.0.42 in runelite-client/pom.xml. Additionally, the PR introduces extensive game data constants related to sailing content, including new NPC IDs, Item IDs, Object IDs, Animation IDs, Interface IDs, and various game identifiers. It expands clue scroll locations, agility shortcuts, fishing spots, farming patches, and transportation point locations to support new in-game areas and features. Possibly related PRs
✨ Finishing touches
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (49)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.40.0)runelite-api/src/main/java/net/runelite/api/ItemID.javarunelite-api/src/main/java/net/runelite/api/NpcID.javarunelite-api/src/main/java/net/runelite/api/gameval/InterfaceID.java
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
udpate latest runelite