Skip to content

Comments

2.0.45#1613

Merged
chsami merged 30 commits intomainfrom
development
Nov 22, 2025
Merged

2.0.45#1613
chsami merged 30 commits intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Nov 22, 2025

No description provided.

Adam- and others added 30 commits November 19, 2025 20:33
These methods no longer have any use due to some session-service changes
# Conflicts:
#	cache/pom.xml
#	pom.xml
#	runelite-api/pom.xml
#	runelite-client/pom.xml
#	runelite-client/src/main/java/net/runelite/client/ClientSessionManager.java
#	runelite-client/src/main/java/net/runelite/client/SessionClient.java
#	runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsOverlay.java
#	runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsPlugin.java
#	runelite-jshell/pom.xml
#	runelite-maven-plugin/pom.xml
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates the parent POM version from 1.12.5.2 to 1.12.6 across all modules and enables the maven-javadoc-plugin with configuration for generated sources. It introduces world entity support APIs including the WorldEntity interface enhancements (getConfig(), getOwnerType()), a new WorldEntityConfig interface, WorldView projection nullability annotations, and a SET_HEADING MenuAction constant. Client-side changes include multi-world-view rendering support in DevToolsOverlay, event-driven world view handling in XteaPlugin and WorldService, session management adjustments in ClientSessionManager, and plugin updates for boat hiding, ground markers, and animation idle detection. Four new mining site locations are also added to MiningSiteLocation.

Possibly related PRs

  • 2.0.17 #1549: Modifies the microbot.version property in runelite-client/pom.xml being updated here.
  • 2.0.38 #1595: Updates rendering-related interfaces and DrawCallbacks signatures in GpuPlugin and Renderable, aligning with the rendering refactoring in DevToolsOverlay and GpuPlugin.
  • 2.0.36.2 patch runelite version #1592: Updates parent and microbot version properties across multiple POM files in the same manner as this PR.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dfd95ed and b246f01.

⛔ Files ignored due to path filters (1)
  • runelite-client/src/main/resources/net/runelite/client/plugins/gpu/vert.glsl is excluded by !**/*.glsl
📒 Files selected for processing (27)
  • cache/pom.xml (2 hunks)
  • pom.xml (2 hunks)
  • runelite-api/pom.xml (2 hunks)
  • runelite-api/src/main/java/net/runelite/api/MenuAction.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/Perspective.java (4 hunks)
  • runelite-api/src/main/java/net/runelite/api/WorldEntity.java (2 hunks)
  • runelite-api/src/main/java/net/runelite/api/WorldEntityConfig.java (1 hunks)
  • runelite-api/src/main/java/net/runelite/api/WorldView.java (2 hunks)
  • runelite-client/pom.xml (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/ClientSessionManager.java (3 hunks)
  • runelite-client/src/main/java/net/runelite/client/SessionClient.java (3 hunks)
  • runelite-client/src/main/java/net/runelite/client/game/WorldService.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/camera/CameraPlugin.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsOverlay.java (9 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsPanel.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/devtools/DevToolsPlugin.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/entityhider/EntityHiderConfig.java (6 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/entityhider/EntityHiderPlugin.java (4 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/gpu/GpuPlugin.java (5 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers/GroundMarkerOverlay.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers/GroundMarkerPlugin.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/idlenotifier/IdleNotifierPlugin.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/mousehighlight/MouseHighlightOverlay.java (1 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/worldmap/MiningSiteLocation.java (2 hunks)
  • runelite-client/src/main/java/net/runelite/client/plugins/xtea/XteaPlugin.java (3 hunks)
  • runelite-jshell/pom.xml (1 hunks)
  • runelite-maven-plugin/pom.xml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit fc3bd32 into main Nov 22, 2025
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants