Skip to content

Comments

build(release): update strip_components for artifact deployment#1632

Merged
chsami merged 1 commit intomainfrom
development
Dec 23, 2025
Merged

build(release): update strip_components for artifact deployment#1632
chsami merged 1 commit intomainfrom
development

Conversation

@chsami
Copy link
Owner

@chsami chsami commented Dec 23, 2025

build(release): update strip_components for artifact deployment

@chsami chsami merged commit 83d69b3 into main Dec 23, 2025
1 of 2 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request removes all Maven POM files (cache/pom.xml, the root pom.xml, and module POM files for runelite-api, runelite-client, runelite-jshell, and runelite-maven-plugin) from the repository while also modifying the release workflow to increase the strip\_components parameter from 2 to 3 when uploading the JAR artifact to Hetzner.

Inconsistency note: The release workflow is being updated to handle different artifact path structures while the entire Maven build configuration is simultaneously being deleted, which suggests either an incomplete transition or migration to an alternative build system.

Possibly related PRs

  • 2.0.45 #1613: Modifies the same set of Maven POM files being deleted in this PR (cache/pom.xml, pom.xml, runelite-api/pom.xml, runelite-client/pom.xml, runelite-jshell/pom.xml, runelite-maven-plugin/pom.xml)
  • 2.0.43 #1612: Updates parent versions in multiple POM files that are removed by this change
  • 2.0.36 #1589: Modifies cache/pom.xml, which is entirely deleted in this PR

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8489bbf and f7e7368.

📒 Files selected for processing (7)
  • .github/workflows/release.yml
  • cache/pom.xml
  • pom.xml
  • runelite-api/pom.xml
  • runelite-client/pom.xml
  • runelite-jshell/pom.xml
  • runelite-maven-plugin/pom.xml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant