Conversation
- changed rewinder file name taking off mmif_. - changed _delete_last function name to be single underscored. - added CLI argument for number of views to rewind. - changed read_mmif from json.load() -> file.read()
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #191 +/- ##
===========================================
- Coverage 77.05% 73.69% -3.36%
===========================================
Files 7 9 +2
Lines 645 730 +85
===========================================
+ Hits 497 538 +41
- Misses 148 192 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* optimized MMIF file I/O * added rewinding by number of apps (opposed to number of views, not exposed in CLI)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening of clamsproject/mmif-python#250. Fixes #190.