Conversation
PR Review: docs: add Docker installation to READMEsThis is a clean, straightforward documentation addition. The Docker command is technically correct and aligns well with the existing Dockerfile. A few observations: Correctness ✓
Issues / SuggestionsMinor: Extra blank line in non-English READMEs
-
-
### DockerSuggestion: Version-pinned example Using docker run -it --rm \
-v ~/.aws:/home/claws/.aws:ro \
ghcr.io/clawscli/claws:latest # or pin: ghcr.io/clawscli/claws:v1.2.3Suggestion: Show how to pass claws flags The Quick Start section (right below) shows profile/region flags like docker run -it --rm \
-v ~/.aws:/home/claws/.aws:ro \
ghcr.io/clawscli/claws -p myprofile -r us-west-2Suggestion: AWS environment variable alternative Some users authenticate via environment variables rather than docker run -it --rm \
-e AWS_ACCESS_KEY_ID \
-e AWS_SECRET_ACCESS_KEY \
-e AWS_SESSION_TOKEN \
ghcr.io/clawscli/clawsSummaryThe core change is correct and a welcome addition. The extra blank line issue is a trivial fix. The other suggestions are optional improvements — feel free to leave them for a follow-up PR if you prefer to keep this focused. |
PR Review: docs: add Docker installation to READMEsOverall this is a clean, well-structured docs addition. The command is consistent across all four language READMEs, correctly uses CorrectnessThe volume mount path Suggestions1. No image tag specified ghcr.io/clawscli/claws # implicitly pulls :latest
# pin to a specific release (recommended for reproducibility)
docker run -it --rm \
-v ~/.aws:/home/claws/.aws:ro \
ghcr.io/clawscli/claws:v0.x.y2. Passing CLI arguments The Quick Start section shows flags like # Example: specify profile and region
docker run -it --rm \
-v ~/.aws:/home/claws/.aws:ro \
ghcr.io/clawscli/claws -p myprofile -r us-west-23. Users without a Some users authenticate via environment variables ( docker run -it --rm \
-e AWS_ACCESS_KEY_ID \
-e AWS_SECRET_ACCESS_KEY \
-e AWS_SESSION_TOKEN \
ghcr.io/clawscli/clawsMinor
None of the above are blockers — the current command works correctly for the common case. The suggestions are enhancements to cover more user scenarios. Happy to approve as-is or with the additions if the maintainers agree they add value. |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [github:clawscli/claws](https://github.com/clawscli/claws) | patch | `0.15.0` → `0.15.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>clawscli/claws (github:clawscli/claws)</summary> ### [`v0.15.1`](https://github.com/clawscli/claws/releases/tag/v0.15.1) [Compare Source](clawscli/claws@v0.15.0...v0.15.1) #### Changelog - [`4fe75b6`](clawscli/claws@4fe75b6) Add docker support and github CR package workflow - [`92189e5`](clawscli/claws@92189e5) Cross-compile for multiple archs instead of relying on QEMU - [`63731ed`](clawscli/claws@63731ed) Merge pull request [#​165](clawscli/claws#165) from clawscli/develop - [`d806a8e`](clawscli/claws@d806a8e) Merge pull request [#​167](clawscli/claws#167) from stefan-matic/main - [`f508583`](clawscli/claws@f508583) Merge pull request [#​168](clawscli/claws#168) from clawscli/develop - [`7fbf05d`](clawscli/claws@7fbf05d) Merge pull request [#​169](clawscli/claws#169) from dpalvolgyi-pw/feature/ecs-last-deployment - [`87d9644`](clawscli/claws@87d9644) Merge pull request [#​170](clawscli/claws#170) from clawscli/develop - [`6d22155`](clawscli/claws@6d22155) feat(ecs): add last deployment column </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4zMS4xIiwidXBkYXRlZEluVmVyIjoiNDMuMzEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
Summary