v0.15.1

[yimsk]

Summary

• Docker support with GHCR publishing workflow (Add docker support and github CR package workflow #167)
• ECS services: add last deployment column (Add last deployment column #169)
• Docker installation docs for all READMEs (docs: add Docker installation to READMEs #168)

[claude]

Code Review

Overall this is a clean, useful addition. A few things worth addressing:

---

Bug: svc.Deployments() called twice per loop iteration

render.go:80-81:

for i := range svc.Deployments() {
    dep := &svc.Deployments()[i]

Deployments() is called on every iteration to get both the range and the element. While the method is a simple return r.Item.Deployments so it won't diverge, taking &svc.Deployments()[i] is taking an address into a different (though identically-backed) slice header than the range expression evaluated. Store the result once:

deployments := svc.Deployments()
for i := range deployments {
    dep := &deployments[i]

---

Logic issue: mixing UpdatedAt and CreatedAt in the same comparison

render.go:83-94:

if dep.UpdatedAt != nil && (latestTime == nil || dep.UpdatedAt.After(*latestTime)) {
    latest = dep
    latestTime = dep.UpdatedAt
    continue
}
if dep.CreatedAt != nil && (latestTime == nil || dep.CreatedAt.After(*latestTime)) {
    latest = dep
    latestTime = dep.CreatedAt
}

Consider a case where deployment A sets latestTime = A.UpdatedAt = T1, and then deployment B has B.UpdatedAt = T0 < T1 (first if fails, no continue) but B.CreatedAt = T2 > T1 (second if succeeds). The result is that B is selected as "latest" based on CreatedAt, even though A has a more recent UpdatedAt. This seems unlikely in practice but is logically inconsistent.

A cleaner approach picks the best available timestamp per deployment before comparing:

deployments := svc.Deployments()
for i := range deployments {
    dep := &deployments[i]
    var t *time.Time
    switch {
    case dep.UpdatedAt != nil:
        t = dep.UpdatedAt
    case dep.CreatedAt != nil:
        t = dep.CreatedAt
    }
    if t != nil && (latestTime == nil || t.After(*latestTime)) {
        latest = dep
        latestTime = t
    }
}

---

Minor: inconsistent fallback value on type assertion failure

Other column getters (getStatus, getDesired, etc.) return "" when the type assertion to *ServiceResource fails. getLastDeployment returns "-". Either is fine but it's worth being consistent.

---

Missing tests

There are no tests in the services package, and none are added here. The logic in getLatestDeployment (especially the timestamp selection) would benefit from a unit test covering edge cases (nil UpdatedAt, nil CreatedAt, empty deployments slice, multiple deployments). Low priority given the rest of the codebase appears to be in the same state, but the logic bug above makes tests more worthwhile.

---

Nit: column width

Width 26 for "LAST DEPLOYMENT" fits the header (15 chars) comfortably, and "in progress - 365d" is 18 chars. Looks fine.

---

Summary: The feature is useful and the code is readable. The logic bug in getLatestDeployment (mixing UpdatedAt/CreatedAt in the cross-deployment comparison) is the main thing worth fixing before merging.