Skip to content

Conversation

@alexcarpenter
Copy link
Member

Description

Fixes issue where the undefined locale keys from localizations were not properly falling back to the english keys.

BEFORE AFTER
Screenshot 2025-12-16 at 9 52 44 AM Screenshot 2025-12-16 at 9 50 25 AM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Fixed localization fallback so undefined entries in custom translations no longer override base language; missing values now correctly fall back to English defaults, preventing gaps in displayed text and improving consistency across locales.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2025

🦋 Changeset detected

Latest commit: bbaccf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 17, 2025 4:48pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch alexcarpenter/fix-locale-fallback-logic

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 16, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7479

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7479

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7479

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7479

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7479

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7479

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7479

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7479

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7479

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7479

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7479

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7479

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7479

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7479

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7479

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7479

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7479

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7479

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7479

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7479

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7479

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7479

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7479

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7479

commit: bbaccf2

alexcarpenter and others added 2 commits December 17, 2025 11:43
Co-authored-by: Dylan Staley <88163+dstaley@users.noreply.github.com>
…ion.test.tsx

Co-authored-by: Dylan Staley <88163+dstaley@users.noreply.github.com>
@alexcarpenter
Copy link
Member Author

closing in favor of #7494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants