-
Notifications
You must be signed in to change notification settings - Fork 423
fix(clerk-js): Ensure localizations fallback to english locale when key is undefined #7479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Ensure localizations fallback to english locale when key is undefined #7479
Conversation
🦋 Changeset detectedLatest commit: bbaccf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
packages/clerk-js/src/ui/localization/__tests__/parseLocalization.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Dylan Staley <88163+dstaley@users.noreply.github.com>
…ion.test.tsx Co-authored-by: Dylan Staley <88163+dstaley@users.noreply.github.com>
|
closing in favor of #7494 |
Description
Fixes issue where the undefined locale keys from localizations were not properly falling back to the english keys.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.