Skip to content

Conversation

@alexcarpenter
Copy link
Member

Description

Fixes an issue where locales with undefined values for keys were not properly falling back to english values.

BEFORE AFTER
Screenshot 2025-12-16 at 9 52 44 AM Screenshot 2025-12-16 at 9 50 25 AM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

🦋 Changeset detected

Latest commit: 5ae239e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/shared Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/types Patch
@clerk/vue Patch
@clerk/localizations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 17, 2025 8:10pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch alexcarpenter/fix-locale-fallback-2

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexcarpenter alexcarpenter changed the title fix(shared): Ensure english locale fallback behvior fix(shared): Ensure localizations fallback to english locale when key is undefined Dec 17, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7494

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7494

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7494

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7494

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7494

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7494

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7494

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7494

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7494

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7494

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7494

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7494

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7494

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7494

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7494

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7494

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7494

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7494

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7494

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7494

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7494

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7494

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7494

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7494

commit: 5ae239e

@alexcarpenter alexcarpenter merged commit 79eb5af into release/core-2 Dec 17, 2025
44 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/fix-locale-fallback-2 branch December 17, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants