Skip to content

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Dec 16, 2025

Description

Follow up to #7470, adding waitlist translations

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Waitlist feature now includes localization support for 17 new languages with fully translated UI labels, buttons, and success messages. Newly supported languages include Arabic, Catalan, Danish, Greek, Finnish, Croatian, Hungarian, Icelandic, Italian, Korean, Mongolian, Norwegian, Serbian, Swedish, Ukrainian, Simplified Chinese, and Traditional Chinese.

✏️ Tip: You can customize this high-level summary in your review settings.

wobsoriano and others added 2 commits December 16, 2025 11:19
Co-authored-by: valentinogagliardi <valentinogagliardi@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2025

🦋 Changeset detected

Latest commit: 6df1ff2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Dec 16, 2025 7:23pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Walkthrough

This PR introduces localization strings for a waitlist feature across 17 language variants in the @clerk/localizations package. Each language file receives translations for waitlist.start and waitlist.success sections, replacing previously undefined placeholder values with concrete localized text. A corresponding changeset documents the patch-level update.

Changes

Cohort / File(s) Summary
Changeset
.changeset/hungry-icons-compete.md
Added changeset documenting patch version bump for @clerk/localizations with note "Added waitlist translations."
Localization translations (17 languages)
packages/localizations/src/{ar-SA.ts, ca-ES.ts, da-DK.ts, el-GR.ts, fi-FI.ts, hr-HR.ts, hu-HU.ts, is-IS.ts, it-IT.ts, ko-KR.ts, mn-MN.ts, nb-NO.ts, sr-RS.ts, sv-SE.ts, uk-UA.ts, zh-CN.ts, zh-TW.ts}
Populated waitlist.start (actionLink, actionText, formButton, subtitle, title) and waitlist.success (message, subtitle, title) fields with localized strings for each language, replacing previously undefined placeholders.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Spot-check translations across a representative sample of language files to ensure consistency in structure and proper placeholder replacement
  • Verify changeset accuracy and alignment with the package version strategy

Poem

🐰 Across seventeen tongues, we hop with glee,
Waitlist words now set translators free!
From Arabic to Mandarin so bright,
No more undefined—each string's just right! 📝✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(localizations): Add waitlist translations' directly and accurately summarizes the main change in the pull request—adding translations for waitlist functionality across multiple language localization files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/waitlist-localization

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cbe5cdc and 6df1ff2.

📒 Files selected for processing (18)
  • .changeset/hungry-icons-compete.md (1 hunks)
  • packages/localizations/src/ar-SA.ts (1 hunks)
  • packages/localizations/src/ca-ES.ts (1 hunks)
  • packages/localizations/src/da-DK.ts (1 hunks)
  • packages/localizations/src/el-GR.ts (1 hunks)
  • packages/localizations/src/fi-FI.ts (1 hunks)
  • packages/localizations/src/hr-HR.ts (1 hunks)
  • packages/localizations/src/hu-HU.ts (1 hunks)
  • packages/localizations/src/is-IS.ts (1 hunks)
  • packages/localizations/src/it-IT.ts (1 hunks)
  • packages/localizations/src/ko-KR.ts (1 hunks)
  • packages/localizations/src/mn-MN.ts (1 hunks)
  • packages/localizations/src/nb-NO.ts (1 hunks)
  • packages/localizations/src/sr-RS.ts (1 hunks)
  • packages/localizations/src/sv-SE.ts (1 hunks)
  • packages/localizations/src/uk-UA.ts (1 hunks)
  • packages/localizations/src/zh-CN.ts (1 hunks)
  • packages/localizations/src/zh-TW.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (10)
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

All code must pass ESLint checks with the project's configuration

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use Prettier for consistent code formatting

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

TypeScript is required for all packages

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Follow established naming conventions (PascalCase for components, camelCase for variables)

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

packages/**/src/**/*.{ts,tsx,js,jsx}: Maintain comprehensive JSDoc comments for public APIs
Use tree-shaking friendly exports
Validate all inputs and sanitize outputs
All public APIs must be documented with JSDoc
Use dynamic imports for optional features
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Implement proper logging with different levels

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.ts?(x)

📄 CodeRabbit inference engine (.cursor/rules/development.mdc)

Use proper TypeScript error types

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/typescript.mdc)

**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoid any type - prefer unknown when type is uncertain, then narrow with type guards
Implement type guards for unknown types using the pattern function isType(value: unknown): value is Type
Use interface for object shapes that might be extended
Use type for unions, primitives, and computed types
Prefer readonly properties for immutable data structures
Use private for internal implementation details in classes
Use protected for inheritance hierarchies
Use public explicitly for clarity in public APIs
Use mixins for shared behavior across unrelated classes in TypeScript
Use generic constraints with bounded type parameters like <T extends { id: string }>
Use utility types like Omit, Partial, and Pick for data transformation instead of manual type construction
Use discriminated unions instead of boolean flags for state management and API responses
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation at the type level
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Document functions with JSDoc comments including @param, @returns, @throws, and @example tags
Create custom error classes that extend Error for specific error types
Use the Result pattern for error handling instead of throwing exceptions
Use optional chaining (?.) and nullish coalescing (??) operators for safe property access
Let TypeScript infer obvious types to reduce verbosity
Use const assertions with as const for literal types
Use satisfies operator for type checking without widening types
Declare readonly arrays and objects for immutable data structures
Use spread operator and array spread for immutable updates instead of mutations
Use lazy loading for large types...

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use ESLint with custom configurations tailored for different package types

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
**/*.{js,ts,jsx,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Use Prettier for code formatting across all packages

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
packages/localizations/**/*

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Organize localization translations in packages/localizations/ with support for 30+ languages and RTL language support

Files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
🧠 Learnings (1)
📚 Learning: 2025-12-12T19:54:17.554Z
Learnt from: wobsoriano
Repo: clerk/javascript PR: 7447
File: packages/localizations/src/en-US.ts:904-905
Timestamp: 2025-12-12T19:54:17.554Z
Learning: In Clerk's JavaScript localization files (packages/localizations/src/*.ts), undefined values for localization keys are intentional and should not be flagged as issues. When a key is undefined, the system uses the default message from the API response as a fallback. Do not flag these as errors; preserve this expected behavior.

Applied to files:

  • packages/localizations/src/hu-HU.ts
  • packages/localizations/src/mn-MN.ts
  • packages/localizations/src/ar-SA.ts
  • packages/localizations/src/sr-RS.ts
  • packages/localizations/src/fi-FI.ts
  • packages/localizations/src/ko-KR.ts
  • packages/localizations/src/it-IT.ts
  • packages/localizations/src/is-IS.ts
  • packages/localizations/src/zh-CN.ts
  • packages/localizations/src/hr-HR.ts
  • packages/localizations/src/ca-ES.ts
  • packages/localizations/src/uk-UA.ts
  • packages/localizations/src/el-GR.ts
  • packages/localizations/src/zh-TW.ts
  • packages/localizations/src/sv-SE.ts
  • packages/localizations/src/nb-NO.ts
  • packages/localizations/src/da-DK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (27)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (18)
packages/localizations/src/uk-UA.ts (1)

1352-1361: Waitlist strings added with correct shape and semantics

waitlist.start and waitlist.success use the expected keys, match the join/success flow used in other locales, and introduce no syntax or typing issues. Undefined values for other keys remain untouched, preserving fallback behavior.

packages/localizations/src/sv-SE.ts (1)

1356-1365: Consistent Swedish waitlist translations

The waitlist.start and waitlist.success entries follow the established key pattern and accurately express the join and success states without introducing any structural or syntax issues.

packages/localizations/src/fi-FI.ts (1)

1356-1365: Finnish waitlist block matches shared schema

The Finnish waitlist.start and waitlist.success strings use the correct keys and mirror the intended flow (join queue, notify when ready, redirect), with no structural or type concerns.

packages/localizations/src/zh-CN.ts (1)

1320-1329: Simplified Chinese waitlist text correctly wired

The waitlist.start and waitlist.success entries are added with the same keys and ordering as other locales, and cleanly express login, joining the候补名单, and success/redirect messaging without syntax issues.

packages/localizations/src/zh-TW.ts (1)

1318-1327: Traditional Chinese waitlist entries align with locale pattern

The waitlist.start and waitlist.success strings for zh-TW mirror the shared schema and semantics used in other locales, with no structural, syntax, or typing issues introduced.

packages/localizations/src/is-IS.ts (1)

1358-1371: Waitlist block matches expected shape and reads consistently

waitlist.start and waitlist.success define all expected keys with Icelandic strings, no placeholder issues, and a tone aligned with the rest of the locale file. No changes needed. Not flagging other undefined keys here since they intentionally fall back to API defaults, as per prior repo guidance.

packages/localizations/src/mn-MN.ts (1)

1354-1367: Mongolian waitlist translations are structurally correct

The waitlist.start/success sections define the full key set with plausible Mongolian copy and no placeholder or syntax issues. Looks good as a localized mirror of the English waitlist flow.

packages/localizations/src/ca-ES.ts (1)

1359-1372: Catalan waitlist strings align with the shared key contract

All expected waitlist.start and waitlist.success keys are populated with Catalan text; quoting and punctuation are correct, and semantics closely follow the base English copy. No further changes needed.

packages/localizations/src/ar-SA.ts (1)

1343-1356: Arabic waitlist localization is complete and consistent

waitlist.start/success include the full key set with Arabic strings that mirror the intended flow (“join waitlist”, email prompt, redirect and thanks). Structure and syntax are consistent with other locales.

packages/localizations/src/ko-KR.ts (1)

1336-1349: Korean waitlist block correctly fills all expected keys

The newly added waitlist.start and waitlist.success strings are idiomatic Korean, cover the same UX steps as other locales, and respect the existing resource shape. No code or content issues spotted.

packages/localizations/src/it-IT.ts (1)

1365-1369: Waitlist strings are complete and consistent with the locale

Keys and structure match the existing schema, strings are idiomatic Italian and consistent with nearby sign-in / waitlist copy. No syntax or interpolation issues spotted.

Also applies to: 1372-1374

packages/localizations/src/sr-RS.ts (1)

1352-1356: Serbian waitlist translations align with schema and tone

Keys, structure, and tone (Cyrillic, informal 2nd person) match the rest of sr-RS and the expected waitlist UX. No issues with syntax or missing placeholders.

Also applies to: 1359-1361

packages/localizations/src/da-DK.ts (1)

1352-1356: Danish waitlist copy looks correct and consistent

New waitlist strings follow the existing localization pattern and read naturally in Danish, with correct keys and no formatting issues.

Also applies to: 1359-1361

packages/localizations/src/hu-HU.ts (1)

1357-1361: Hungarian waitlist translations integrate cleanly

Keys and semantics match other locales, style matches existing hu-HU text, and there are no type or syntax concerns.

Also applies to: 1364-1366

packages/localizations/src/hr-HR.ts (1)

1360-1364: Croatian waitlist strings are well-formed and on-brand

The new waitlist translations use the correct keys, read naturally in Croatian, and are consistent with the rest of the locale file.

Also applies to: 1367-1369

packages/localizations/src/nb-NO.ts (1)

1352-1365: LGTM! Waitlist translations added correctly.

The Norwegian waitlist translations are well-structured and consistent with the existing localization patterns in this file. The addition includes both the start flow (join waitlist) and success state with appropriate Norwegian text.

packages/localizations/src/el-GR.ts (1)

1362-1376: LGTM! Greek waitlist translations added correctly.

The Greek waitlist translations are properly structured and consistent with both the file's existing translation style and the pattern used across other locales in this PR. All required keys for the waitlist feature are present and correctly nested.

.changeset/hungry-icons-compete.md (1)

1-5: LGTM! Changeset properly documents the translation additions.

The changeset correctly identifies this as a patch-level update for @clerk/localizations and provides a clear description of the changes.


Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsoriano wobsoriano requested a review from tmilewski December 16, 2025 19:22
@wobsoriano
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 16, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7483

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7483

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7483

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7483

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7483

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7483

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7483

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7483

commit: 6df1ff2

@wobsoriano wobsoriano merged commit 54cd476 into release/core-2 Dec 16, 2025
77 of 79 checks passed
@wobsoriano wobsoriano deleted the rob/waitlist-localization branch December 16, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants