Parse timestamp can return nil. Check for nil.#187
Merged
Conversation
n3wscott
force-pushed
the
nill-ptr-dateparse
branch
from
51d59a5 to
ef0eb34
Compare
Contributor
|
LGTM |
markpeek
reviewed
Sep 13, 2019
Contributor
markpeek
left a comment
markpeek
left a comment
There was a problem hiding this comment.
Just a couple of comments but LGTM for merging.
| if err := ec.SetTime(timestamp.Time); err != nil { | ||
| return err | ||
| if t, ok := h[prefix+"time"].(string); ok { | ||
| if timestamp := types.ParseTimestamp(t); timestamp != nil { |
Contributor
There was a problem hiding this comment.
Right now ParseTimestamp() doesn't return an error. It's debatable on what to do if there is a bad time being presented whether to fail entirely or, as in the case, silently drop. Perhaps open an issue?
Member
Author
There was a problem hiding this comment.
good points, I was optimizing for moving fast but it is true that this could catch someone off guard... I caught myself off guard. :D
| @@ -187,16 +187,16 @@ func (c Codec) fromAttributes(a map[string]string, event *cloudevents.Event) err | |||
| delete(a, prefix+"source") | |||
|
|
|||
| if t := a[prefix+"time"]; t != "" { | |||
Contributor
There was a problem hiding this comment.
This looks suspiciously similar to the amqp codec code. Perhaps there needs to be helpers in the main code for the codecs to use.
Member
Author
There was a problem hiding this comment.
they use a slightly different mapping ... grrrr
I have some ideas how to combine them and pass a mapping decoder ring for the future.
n3wscott
added a commit
to n3wscott/sdk-go
that referenced
this pull request
Sep 20, 2019
Signed-off-by: Scott Nichols <nicholss@google.com>
n3wscott
added a commit
to n3wscott/sdk-go
that referenced
this pull request
Sep 20, 2019
Signed-off-by: Scott Nichols <nicholss@google.com>
n3wscott
added a commit
that referenced
this pull request
Sep 20, 2019
* starting to add context for 0.4 Signed-off-by: Scott Nichols <nicholss@google.com> * Enabling Pub/Sub to send and receive from multiple topics and subscriptions. (#171) Signed-off-by: Scott Nichols <nicholss@google.com> * Code and examples for proposed changes/additions to transport APIs (#164) Please see the code and doc for details. Signed-off-by: Alan Conway <aconway@redhat.com> Signed-off-by: Scott Nichols <nicholss@google.com> * fix a syntax error in a logw line. (#174) Signed-off-by: Scott Nichols <nicholss@google.com> * Changing Send signature: Adding Context return param (#177) Signed-off-by: nachocano <nachoacano@gmail.com> Signed-off-by: Scott Nichols <nicholss@google.com> * Renamed pkg/cloudevents/transport/x to pkg/binding (#181) Main types are binding.Message, binding.Sender and binding.Receiver which reads well in code, corresponds to CE spec use of the term "binding", and avoids clashes with existing package name "transport". Part of #180 - The AMQP transport will be re-factored to use this package. Signed-off-by: Alan Conway <aconway@redhat.com> Signed-off-by: Scott Nichols <nicholss@google.com> * fix extra header write. (#179) Signed-off-by: Scott Nichols <nicholss@google.com> * fix codec v0.3 double quote encoding (#184) Signed-off-by: Diego Marangoni <diegomarangoni@me.com> Signed-off-by: Scott Nichols <nicholss@google.com> * Propagate pubsub subscriber errors (#185) * Found a blocking issue on pubsub transport if a subscriber had an error. Signed-off-by: Scott Nichols <nicholss@google.com> * make sure cancel is called Signed-off-by: Scott Nichols <nicholss@google.com> * go mod. Signed-off-by: Scott Nichols <nicholss@google.com> Signed-off-by: Scott Nichols <nicholss@google.com> * Fix nil pointer exception in codec timestamp handling (#187) Signed-off-by: Scott Nichols <nicholss@google.com> * Leaked a debug line. (#189) Signed-off-by: Scott Nichols <nicholss@google.com> * preping for v1.0, adjusting the interfaces. Signed-off-by: Scott Nichols <nicholss@google.com> * fix a typo on the godoc. Signed-off-by: Scott Nichols <nicholss@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nachocano found a npe in his logs. I think this will fix.