Starting to add 1.0#194
Merged
Merged
Conversation
Signed-off-by: Scott Nichols <nicholss@google.com>
…ptions. (cloudevents#171) Signed-off-by: Scott Nichols <nicholss@google.com>
…loudevents#164) Please see the code and doc for details. Signed-off-by: Alan Conway <aconway@redhat.com> Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: nachocano <nachoacano@gmail.com> Signed-off-by: Scott Nichols <nicholss@google.com>
Main types are binding.Message, binding.Sender and binding.Receiver which reads well in code, corresponds to CE spec use of the term "binding", and avoids clashes with existing package name "transport". Part of cloudevents#180 - The AMQP transport will be re-factored to use this package. Signed-off-by: Alan Conway <aconway@redhat.com> Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Diego Marangoni <diegomarangoni@me.com> Signed-off-by: Scott Nichols <nicholss@google.com>
* Found a blocking issue on pubsub transport if a subscriber had an error. Signed-off-by: Scott Nichols <nicholss@google.com> * make sure cancel is called Signed-off-by: Scott Nichols <nicholss@google.com> * go mod. Signed-off-by: Scott Nichols <nicholss@google.com> Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
markpeek
requested changes
Sep 20, 2019
Contributor
markpeek
left a comment
markpeek
left a comment
There was a problem hiding this comment.
Looks good. Found one issue to change.
| return "" | ||
| } | ||
|
|
||
| // DataContentEncoding implements EventReader.DataContentEncoding |
Contributor
There was a problem hiding this comment.
Likely this was an earlier type since it should be for Extensions().
Signed-off-by: Scott Nichols <nicholss@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the v1.0 context for conforming to the new release of CloudEvents 1.0-rc1
This is the first of many updates to migrate the SDK to
v1.0.