Skip to content

add ref to RFC2119 and href checker#3

Merged
duglin merged 1 commit into
cloudevents:masterfrom
duglin:notations
Jan 11, 2018
Merged

add ref to RFC2119 and href checker#3
duglin merged 1 commit into
cloudevents:masterfrom
duglin:notations

Conversation

@duglin
Copy link
Copy Markdown
Collaborator

@duglin duglin commented Jan 7, 2018

Any good spec needs to use RFC2119 keywords, so this starts us down that path
by added a ref to it. Doesn't introduce any uses of the keywords yet.

Added an href checker tool so that we can make sure we don't have any
bad hrefs in our docs.

Also added a travis hook so we run the verification script as our build.

Signed-off-by: Doug Davis dug@us.ibm.com

Any good spec needs to use RFC2119 keywords, so this starts us down that path
by added a ref to it. Doesn't introduce any uses of the keywords yet.

Added an href checker tool so that we can make sure we don't have any
bad hrefs in our docs.

Also added a travis hook so we run the verification script as our build.

Signed-off-by: Doug Davis <dug@us.ibm.com>
@caniszczyk
Copy link
Copy Markdown
Contributor

LGTM

@duglin
Copy link
Copy Markdown
Collaborator Author

duglin commented Jan 8, 2018

Just a reminder for people, per the proposed governance process, we will be approving PRs during our calls. We will not be using a traditional "LGTM" process yet. However, people should still LGTM (or "NOT LGTM" w/comments) in PRs to express their (dis)agreement with the PRs. This will help us know which have general consensus and can be quickly approved during our calls.

Copy link
Copy Markdown
Contributor

@markito markito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duglin duglin merged commit 0214794 into cloudevents:master Jan 11, 2018
@duglin duglin deleted the notations branch February 1, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants