Skip to content

Update spec with OpenStack Event#51

Merged
duglin merged 2 commits into
cloudevents:masterfrom
notque:patch-1
Feb 22, 2018
Merged

Update spec with OpenStack Event#51
duglin merged 2 commits into
cloudevents:masterfrom
notque:patch-1

Conversation

@notque
Copy link
Copy Markdown
Contributor

@notque notque commented Jan 31, 2018

Add OpenStack event example to references.

Signed-off-by: Nathan Oyler nathan.oyler@sap.com

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Jan 31, 2018

@notque see: #19
I think that entire section will be moved into a different doc. Perhaps you could use this PR to start that process? Meaning, 1) start a new doc, 2) move that References section into the new doc, 3) add the OpenStack event stuff into it. WDYT?

@notque
Copy link
Copy Markdown
Contributor Author

notque commented Jan 31, 2018

@duglin is that fair?

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Jan 31, 2018

yes! excellent! thanks!

If its ok with you, I'll assign you as the owner of #19 since you already did the work ;-)
I think you just now need to sign your commits so that the DCO checker is happy.

@notque
Copy link
Copy Markdown
Contributor Author

notque commented Jan 31, 2018

I've signed my commits, did I miss one? What is the most reasonable way to clear it?

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Jan 31, 2018

I think if you squash it down to one and make sure that one is signed then it might help.
Also make sure you sign it via the "-s" flag on "git commit". It expects it in a certain format (something like: Signed-off-by: xxx xxx@xxx.com ) and its kind of picky about each char.
Make sure your git config user.name matches what appears in the git log too.

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Feb 2, 2018

rebase needed

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Feb 5, 2018

@notque can you rebase this? I think we can get this one merged this week - seems pretty straightforward.

@austencollins
Copy link
Copy Markdown
Contributor

Good addition, @notque. Thanks!

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Feb 8, 2018

@notque if you need help with your DCO or squashing ping me via slack (or here)

@notque
Copy link
Copy Markdown
Contributor Author

notque commented Feb 8, 2018

@duglin Looking into the details of our agreement with CNCF, I actually have to jump through more hoops than I anticipated (as our team contributes to open source regularly), given that I am waiting for the right approval. Once that happens I can squash.

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Feb 8, 2018

ok thanks for the update

@ultrasaurus
Copy link
Copy Markdown
Contributor

oops -- missed this! I just did a PR to move the references section out of the spec: #89

@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Feb 20, 2018

@notque any update on your CLA?

Add OpenStack event example to references.
create reference.md doc
move references from spec
update spec with references link

Signed-off-by: Nathan Oyler <nathan.oyler@sap.com>
@duglin duglin removed the needs work label Feb 22, 2018
@duglin
Copy link
Copy Markdown
Collaborator

duglin commented Feb 22, 2018

Approved on 2/22 call

@duglin duglin merged commit bf9cf67 into cloudevents:master Feb 22, 2018
@notque notque deleted the patch-1 branch February 22, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants