move references out of the specification into supporting material#89
Closed
ultrasaurus wants to merge 2 commits into
Closed
move references out of the specification into supporting material#89ultrasaurus wants to merge 2 commits into
ultrasaurus wants to merge 2 commits into
Conversation
Signed-off-by: Sarah Allen <sarahallen@google.com>
duglin
reviewed
Feb 20, 2018
| @@ -0,0 +1,129 @@ | |||
| Prior to the CloudEvents specification, many systems implemented similar models for events that allowed late-binding of services to actions. | |||
Collaborator
There was a problem hiding this comment.
can you wrap this at 80 cols?
Collaborator
|
Do we need a 2-level dir structure just for one file? I'd prefer to not create dirs until we have more than one file that lives in the dir. Also, we'll need some kind of pointer to that file (e.g. from top README?), otherwise its just dangling and no one will find it. |
Collaborator
|
travis error looks real: |
Signed-off-by: Rachel Myers <rachelmyers@google.com>
Collaborator
|
@ultrasaurus can you fix the bad href? |
Collaborator
|
oh and a rebase is needed |
Collaborator
|
I believe this one can be closed - all of the edits appear to already be done via some other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #19
/aboutsince that is the name of the directory in work-in-progress PR starter doc explaining key concepts from the spec #53/landscapesub-directory, since I thought it would be nice to refactor this later into an area with a page for each product/software that implements this type of a system -- currently is for historical context, but in the future could contain references to systems that implement the specSigned-off-by: Sarah Allen sarahallen@google.com