Revert "Redoing "#2073: Update Request to support cache option" with compat flags" #2432
+18
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tewaro
approved these changes
Jul 24, 2024
tewaro
added a commit
that referenced
this pull request
Aug 30, 2024
* Revert "Merge pull request #2432 from cloudflare/revert-2409-jsnell/http-request-cache-part1" This reverts commit e7cd9f4, reversing changes made to d1b6269. * Gate prototypes behind compatability flag for cache: no-store * Check for a validate function to enable an interposition step in JSG_STRUCT * Added documentation to explain validate function * Include the type check within validate * Address nits * Update typescript test * Update typescript overrides * Refactor JSG to add DYNAMIC TS overrides * Run formatter * deleting extra macro definitions * Update jsg.h --------- Co-authored-by: Garrett Gu <garrett@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2409
This broke workers in production again.
Any further attempt to land this change must be reviewed and approved by me before being merged.