-
Notifications
You must be signed in to change notification settings - Fork 496
Http Request Cache Part 1 #2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
905efd7 to
975063b
Compare
3afdcc0 to
0a12f2c
Compare
0a12f2c to
fff5de3
Compare
68a2c75 to
1d13ab0
Compare
5aa3639 to
bf88e9e
Compare
Based on the results of this PR: #2480 the typescript results are no different. Do we want to add tests for every frontend? |
78f8add to
4af033d
Compare
330f6cc to
e2f2390
Compare
e2f2390 to
c147312
Compare
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (from the types generation point of view) 🙂
fe835ed to
a293314
Compare
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! thanks for the ts improvement @AdityaAtulTewari! 🫶
62a34b9 to
30185d5
Compare
|
Does Workers support caching within NextJS? Seems like nothing is cached. Even with KV bindings added. |

RM-18292
refs #698 and cloudflare/workers-sdk#2514
Follow-up to reintroduce the behavior that was reverted in #2432
Updates the Request object to support specifying a cache mode per the standard. Only undefined, 'no-store' and 'no-cache' may be specified, and the fetch implementation specifically does not implement the semantics for either 'no-store' or 'no-cache' yet.
Also adds the compatibility flag for cacheHeaderEnabled. This just lays the ground work for the additional changes.
The next step is to start adding the support for adding the appropriate header fields in the fetch implementation behind an autogate