refactor: rename Flags type to Flagship and prefix exported types#6584
Merged
git-bruh merged 2 commits intocloudflare:mainfrom Apr 15, 2026
Merged
refactor: rename Flags type to Flagship and prefix exported types#6584git-bruh merged 2 commits intocloudflare:mainfrom
git-bruh merged 2 commits intocloudflare:mainfrom
Conversation
petebacondarwin
approved these changes
Apr 15, 2026
git-bruh
approved these changes
Apr 15, 2026
Rename flags.d.ts to flagship.d.ts and update all exported type names: - Flags -> Flagship - EvaluationContext -> FlagshipEvaluationContext - EvaluationDetails -> FlagshipEvaluationDetails - FlagEvaluationError -> FlagshipEvaluationError This aligns workerd types with the Flagship type name used in wrangler's type generation (workers-sdk).
Merging this PR will not alter performance
Comparing 
Footnotes
|
roerohan
force-pushed
the
roerohan/flagship-rename-types
branch
3 times, most recently
from
e4ffde3 to
f9e950f
Compare
roerohan
force-pushed
the
roerohan/flagship-rename-types
branch
from
f9e950f to
dfc3d1a
Compare
danlapid
approved these changes
Apr 15, 2026
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
types/defines/flags.d.tstotypes/defines/flagship.d.tsFlagshipprefix:Flags->FlagshipEvaluationContext->FlagshipEvaluationContextEvaluationDetails->FlagshipEvaluationDetailsFlagEvaluationError->FlagshipEvaluationErrortypes/generated-snapshot/to reflect the new namesMotivation
Wrangler's type generation already references this binding type as
Flagship. This change aligns the workerd type definitions to match, preventing type mismatches for users.