Skip to content

[miniflare] Rename Flags type to Flagship#13558

Merged
emily-shen merged 4 commits intocloudflare:dependabot/npm_and_yarn/workerd-and-workers-types-198f3e4c82from
roerohan:rmukherjee/flags-to-flagship
Apr 16, 2026
Merged

[miniflare] Rename Flags type to Flagship#13558
emily-shen merged 4 commits intocloudflare:dependabot/npm_and_yarn/workerd-and-workers-types-198f3e4c82from
roerohan:rmukherjee/flags-to-flagship

Conversation

@roerohan
Copy link
Copy Markdown
Member

@roerohan roerohan commented Apr 16, 2026

Rename the Flags type import to Flagship to match the upstream rename in @cloudflare/workers-types (cloudflare/workerd#6584).

  • Import: Flags -> Flagship from @cloudflare/workers-types/experimental
  • Return type of getFlagshipBinding: Promise<Flags> -> Promise<Flagship>

Fixes #13557


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: Type-only rename, no runtime behavior change.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal type rename, no user-facing API change.

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 16, 2026

🦋 Changeset detected

Latest commit: ddb6d93

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Apr 16, 2026
@workers-devprod workers-devprod requested review from a team and vicb and removed request for a team April 16, 2026 06:18
@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/index.ts: [@cloudflare/wrangler]

@roerohan roerohan changed the base branch from main to dependabot/npm_and_yarn/workerd-and-workers-types-198f3e4c82 April 16, 2026 06:18
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 16, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13558

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13558

miniflare

npm i https://pkg.pr.new/miniflare@13558

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13558

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13558

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13558

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13558

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13558

wrangler

npm i https://pkg.pr.new/wrangler@13558

commit: ddb6d93

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 16, 2026
@emily-shen emily-shen merged commit 54e0c8a into cloudflare:dependabot/npm_and_yarn/workerd-and-workers-types-198f3e4c82 Apr 16, 2026
50 of 51 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 16, 2026
@roerohan roerohan deleted the rmukherjee/flags-to-flagship branch April 16, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants