Skip to content

fix(wrangler): vectorize list-vectors should output valid json#10517

Merged
edmundhung merged 2 commits intomainfrom
edmundhung/fix-list-vectors-json-output
Sep 3, 2025
Merged

fix(wrangler): vectorize list-vectors should output valid json#10517
edmundhung merged 2 commits intomainfrom
edmundhung/fix-list-vectors-json-output

Conversation

@edmundhung
Copy link
Copy Markdown
Member

Fixes #10508.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: v4 only

@edmundhung edmundhung requested a review from a team as a code owner September 1, 2025 13:50
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 1, 2025

🦋 Changeset detected

Latest commit: 41665e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Sep 1, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10517

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10517

miniflare

npm i https://pkg.pr.new/miniflare@10517

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10517

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10517

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10517

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10517

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10517

wrangler

npm i https://pkg.pr.new/wrangler@10517

commit: 41665e8

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 1, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main edmundhung/fix-list-vectors-json-output might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10517
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@garvit-gupta
Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Sep 3, 2025
@edmundhung edmundhung merged commit 7211609 into main Sep 3, 2025
53 of 57 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-list-vectors-json-output branch September 3, 2025 09:54
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Sep 3, 2025
emily-shen pushed a commit to MaxwellCalkin/workers-sdk that referenced this pull request Mar 10, 2026
…alid json

Wrap the log messages in `if (!args.json)` guards so that
`wrangler vectorize list --json` and
`wrangler vectorize list-metadata-index --json` output only valid JSON
without a preceding human-readable log line.

Follows the same pattern used in PR cloudflare#10517 for list-vectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

wrangler vectorize list-vectors --json outputs a log/message as the first line (not valid json).

4 participants