fix(wrangler): vectorize list and list-metadata-index should output valid json#12807
Merged
emily-shen merged 7 commits intocloudflare:mainfrom Mar 11, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: d1ad964 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Closed
5 tasks
dario-piotrowicz
approved these changes
Mar 10, 2026
Member
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me, besides the changeset which I think that ideally should be updated
6 tasks
emily-shen
reviewed
Mar 10, 2026
emily-shen
reviewed
Mar 10, 2026
…alid json Wrap the log messages in `if (!args.json)` guards so that `wrangler vectorize list --json` and `wrangler vectorize list-metadata-index --json` output only valid JSON without a preceding human-readable log line. Follows the same pattern used in PR cloudflare#10517 for list-vectors.
fb694b9 to
16c6890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11011.
Follows the same pattern as PR #10517 (which fixed
list-vectors --jsonfor #10508).Problem
wrangler vectorize list --jsonandwrangler vectorize list-metadata-index --jsonprint a human-readable log message before the JSON output:This makes stdout invalid JSON and breaks piping to
jqand other tools.Fix
Wrap the
logger.log()calls inif (!args.json)guards so the log message is suppressed when--jsonis used — the same one-line pattern applied in #10517 forlist-vectors.list.ts:listMetadataIndex.ts: