Use vitest#expect from the local context by vicb · Pull Request #12347 · cloudflare/workers-sdk

vicb · 2026-02-01T08:30:55Z

Part of #12346 - focus is on the miniflare package here

The code of this PR was authored by OpenCode/Opus

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: refactoring

A picture of a cute animal (not mandatory, but encouraged)

Part of #12346

changeset-bot · 2026-02-01T08:30:59Z

🦋 Changeset detected

Latest commit: c695c51

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude · 2026-02-01T08:31:17Z

Claude finished @vicb's task —— View job

Changeset Review

Tasks

Read changeset guidelines
Review changeset file
Check for cute animal images
Provide feedback

✅ All changesets look good

The changeset for @cloudflare/eslint-config-shared (patch) is well-formatted and appropriate:

Version type: Patch is correct for adding a new ESLint rule
Description: Clear and explains both what the change does and why
Formatting: No problematic headers
Content: Appropriately concise and informative

devin-ai-integration

Devin Review found 2 potential issues.

View issues and 5 additional flags in Devin Review.

pkg-pr-new · 2026-02-01T08:36:49Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12347

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12347

miniflare

npm i https://pkg.pr.new/miniflare@12347

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12347

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12347

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12347

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12347

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12347

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12347

wrangler

npm i https://pkg.pr.new/wrangler@12347

commit: c695c51

devin-ai-integration

Devin Review found 1 new potential issue.

View issue and 5 additional flags in Devin Review.

dario-piotrowicz

lgtm

dario-piotrowicz · 2026-02-01T15:49:51Z

@@ -1,3 +1,4 @@
+// eslint-disable-next-line workers-sdk/no-vitest-import-expect


why this exception? can you add a comment explaining it?

This is explained in more details in the linked #12346

The idea is to submit multiple larger but PRs convetring the simple/mechanical changes and keep the few changes that will need a more carful review for later - for now ignoring the rule for them.

thanks 🙂, I'm happy with multiple PRs, but again potentially I'd add a TODO code comment linking to #12346 so that we don't forget to enable the rule elsewhere, but I'll leave this up to you 👍

dario-piotrowicz · 2026-02-01T15:50:53Z

 	R2_PLUGIN_NAME,
 	ReplaceWorkersTypes,
 } from "miniflare";
+// eslint-disable-next-line workers-sdk/no-vitest-import-expect


why this exception? can you add a comment explaining it?

vicb · 2026-02-01T16:12:40Z

lgtm

Hey Dario,

I didn't comment on exceptions because they are temp and will be removed soon (~days) as described in the linked issue #12346.

This is only a way to keep reviews reasonably sized and not too time consuming.

Does that sound good?

dario-piotrowicz · 2026-02-02T01:19:56Z

Hey Dario,

I didn't comment on exceptions because they are temp and will be removed soon (~days) as described in the linked issue #12346.

This is only a way to keep reviews reasonably sized and not too time consuming.

Does that sound good?

Sounds good 🙂 (and you know that I really appreciate smaller / reviewable PRs 🙏 )

From my point of view a string replacement from:

// eslint-disable-next-line workers-sdk/no-vitest-import-expect

to

// eslint-disable-next-line workers-sdk/no-vitest-import-expect -- to be handled as part of https://github.com/cloudflare/workers-sdk/issues/12346

seems helpful and it doesn't seem very time consuming, but if you feel that it might be, or if you really find it very unnecessary/problematic, no problem, I'm ok with the code as is 🙂

(PS: I personally feel that todos are valuable even for very temporary changes, since you never know, something unexpected can come up and you might not be able to update the code as quickly as intended, in that case TODOs would still be there as a helpful reminder)

Use vitest#expect from the local context

ff43cd1

Part of #12346

vicb requested review from a team as code owners February 1, 2026 08:30

vicb added the miniflare Relating to Miniflare label Feb 1, 2026

workers-devprod added this to workers-sdk Feb 1, 2026

github-project-automation Bot moved this to Untriaged in workers-sdk Feb 1, 2026

devin-ai-integration Bot reviewed Feb 1, 2026

View reviewed changes

Comment thread packages/miniflare/test/plugins/core/inspector-proxy/index.spec.ts

Comment thread packages/eslint-config-shared/rules/__tests__/no-vitest-import-expect.test.mjs Outdated

vicb added 2 commits February 1, 2026 09:39

fixup! feedback

7a4afc5

fixup! Devin caught a bug in the spec

11419d3

vicb force-pushed the vicb/expect-miniflare branch from 05de6f8 to 11419d3 Compare February 1, 2026 08:47

devin-ai-integration Bot reviewed Feb 1, 2026

View reviewed changes

Comment thread packages/miniflare/test/plugins/core/inspector-proxy/index.spec.ts

dario-piotrowicz approved these changes Feb 1, 2026

View reviewed changes

github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 1, 2026

vicb added 2 commits February 2, 2026 07:26

Merge branch 'main' into vicb/expect-miniflare

59d17cc

fixup! review

c695c51

vicb merged commit 1a1f9e4 into main Feb 2, 2026
39 of 40 checks passed

vicb deleted the vicb/expect-miniflare branch February 2, 2026 07:09

github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 2, 2026

workers-devprod mentioned this pull request Feb 1, 2026

Version Packages #12266

Merged

This was referenced Feb 2, 2026

Use vitest#expect from the local context #12356

Merged

Use vitest#expect from the local context #12373

Merged

Use vitest#expect from the local context #12385

Merged

This was referenced Feb 4, 2026

Use vitest#expect from the local context #12403

Merged

Use vitest#expect from the local context #12412

Merged

Use vitest#expect from the local context #12415

Merged

Use vitest#expect from the local context #12426

Merged

		@@ -1,3 +1,4 @@
		// eslint-disable-next-line workers-sdk/no-vitest-import-expect

Conversation

vicb commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

claude Bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Tasks

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pkg-pr-new Bot commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dario-piotrowicz Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

vicb Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dario-piotrowicz Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vicb commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dario-piotrowicz commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vicb commented Feb 1, 2026 •

edited

Loading

changeset-bot Bot commented Feb 1, 2026 •

edited

Loading

claude Bot commented Feb 1, 2026 •

edited

Loading

pkg-pr-new Bot commented Feb 1, 2026 •

edited

Loading

vicb commented Feb 1, 2026 •

edited

Loading