Use vitest#expect from the local context

[vicb]

Part of #12346
Follow up of #12347

The code changes are courtesy of OpenCode/Opus

Summary

This PR migrates test files to use expect from the local test context instead of importing it from vitest. This change improves concurrency safety when running tests with .concurrent.

Background

When running tests concurrently with Vitest, the global expect imported from vitest can cause issues because it cannot reliably detect which test is running. The Vitest documentation recommends using expect from the local test context instead.

Changes

Before:

import { expect, test } from "vitest";
test("name", () => {
  expect(value).toBe(1);
});

After:

import { test } from "vitest";
test("name", ({ expect }) => {
  expect(value).toBe(1);
});

ESLint Rule

A new ESLint rule workers-sdk/no-vitest-import-expect was added to enforce this pattern. The rule is enabled per-package as they are migrated.
For files with complex patterns (e.g., test.each, helper functions using expect at module scope), an eslint-disable comment is added:

// eslint-disable-next-line workers-sdk/no-vitest-import-expect -- see #12346
import { expect, test } from "vitest";

Migrated Packages

Package	Test Files	Trivial	Complex (disabled)
pages-shared	3	2	1
vitest-pool-workers	1	1	0
edge-preview-authenticated-proxy	1	0	1
playground-preview-worker	1	0	1
containers-shared	3	3	0
workflows-shared	3	2	1
workers-utils	9	3	6
workers-shared	12	0	12

Remaining Packages (future PRs)

• create-cloudflare (31 files)
• vite-plugin-cloudflare (102 files)
• wrangler (216 files)
• fixtures/ (115 files)

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: not a user facing change

A picture of a cute animal (not mandatory, but encouraged)

---

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2488e6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional flags.

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12356

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12356

miniflare

npm i https://pkg.pr.new/miniflare@12356

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12356

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12356

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12356

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12356

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12356

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12356

wrangler

npm i https://pkg.pr.new/wrangler@12356

commit: 2488e6d

[vicb]

Thanks for the review Matt!