Skip to content

[wrangler] Redact email and account names in non-interactive mode#12396

Merged
petebacondarwin merged 2 commits intomainfrom
fix/redact-email-in-non-interactive-mode
Feb 3, 2026
Merged

[wrangler] Redact email and account names in non-interactive mode#12396
petebacondarwin merged 2 commits intomainfrom
fix/redact-email-in-non-interactive-mode

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Feb 3, 2026

Fixes #12389.

This PR redacts email addresses and account names when running in non-interactive mode (e.g., CI environments) to prevent sensitive information from being exposed in public CI logs.

Summary

  • Redact account names in error messages when multiple accounts are available but no account is selected in non-interactive mode
  • Redact email addresses and account names in wrangler whoami output when running in non-interactive mode
  • Account IDs remain visible to aid debugging
  • Updated tests to reflect the new redacted output

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This is a security improvement that doesn't change user-facing behavior in interactive mode

Open with Devin

@petebacondarwin petebacondarwin requested review from a team as code owners February 3, 2026 19:59
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 3, 2026

🦋 Changeset detected

Latest commit: 19c1a84

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Feb 3, 2026

Claude finished @petebacondarwin's task —— View job


Changeset Review

All changesets look good

The changeset .changeset/redact-email-non-interactive.md has been validated:

  • Version Type: patch is appropriate for this security improvement/bug fix
  • Changelog Quality: Clear description explaining what is redacted, why (prevent sensitive info exposure in CI logs), and what remains visible (account IDs for debugging)
  • Markdown Headers: No h1/h2/h3 headers present
  • Analytics: Not applicable - no analytics changes
  • Format: Follows the conventional commit prefix format (fix:) as allowed by guidelines

The changeset correctly captures this security enhancement with sufficient detail for users to understand the change.


Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View issue and 4 additional flags in Devin Review.

Open in Devin Review

Comment thread packages/wrangler/src/user/whoami.ts
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 3, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12396

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12396

miniflare

npm i https://pkg.pr.new/miniflare@12396

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12396

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12396

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12396

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12396

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12396

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12396

wrangler

npm i https://pkg.pr.new/wrangler@12396

commit: 19c1a84

Comment thread packages/wrangler/src/user/whoami.ts
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 3, 2026
@petebacondarwin petebacondarwin merged commit dab4bc9 into main Feb 3, 2026
48 of 49 checks passed
@petebacondarwin petebacondarwin deleted the fix/redact-email-in-non-interactive-mode branch February 3, 2026 20:58
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

wrangler output is a security disaster for public CI logs

3 participants