Skip to content

[wrangler] Stop redacting account names in non-interactive mode#12598

Merged
petebacondarwin merged 4 commits intocloudflare:mainfrom
mattzcarey:unredact-account-names
Feb 19, 2026
Merged

[wrangler] Stop redacting account names in non-interactive mode#12598
petebacondarwin merged 4 commits intocloudflare:mainfrom
mattzcarey:unredact-account-names

Conversation

@mattzcarey
Copy link
Copy Markdown
Contributor

@mattzcarey mattzcarey commented Feb 18, 2026

Relates to #12389, partially reverts #12396.

wrangler whoami is explicitly invoked to retrieve account info, so nothing should be redacted — the user (or agent) is asking for this information. Redacting account names and emails in non-interactive mode (added in #12396) breaks agent and automation workflows that rely on whoami output to identify accounts.

Other code paths that may output account info unexpectedly in CI logs (e.g. the multi-account selection error in getAccountId) remain redacted.

Changes

  • whoami.ts: Remove all redaction logic — account names and email are always shown. Removed isNonInteractiveOrCI import (no longer needed).
  • whoami.test.ts: Updated non-interactive test to expect real email and account names.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No user-facing docs change needed — this restores previous behavior for whoami output.

@mattzcarey mattzcarey requested review from a team as code owners February 18, 2026 14:58
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 18, 2026

🦋 Changeset detected

Latest commit: eb6844a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 18, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12598

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12598

miniflare

npm i https://pkg.pr.new/miniflare@12598

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12598

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12598

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12598

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12598

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12598

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12598

wrangler

npm i https://pkg.pr.new/wrangler@12598

commit: eb6844a

Copy link
Copy Markdown
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like @petebacondarwin to have a look too

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Feb 18, 2026
Account names are not secrets and redacting them in CI/non-interactive
environments breaks agent and automation workflows that need to identify
accounts by name. Email addresses remain redacted as PII.
@petebacondarwin petebacondarwin merged commit ca58062 into cloudflare:main Feb 19, 2026
37 of 38 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants