Skip to content

Graduate c3-vendor runCommand, quoteShellArgs, installPackages and installWrangler to @cloudflare/cli#13068

Merged
dario-piotrowicz merged 1 commit intomainfrom
dario/DEVX-2380/1/graduate-cloudflare-cli-utilities
Mar 30, 2026
Merged

Graduate c3-vendor runCommand, quoteShellArgs, installPackages and installWrangler to @cloudflare/cli#13068
dario-piotrowicz merged 1 commit intomainfrom
dario/DEVX-2380/1/graduate-cloudflare-cli-utilities

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Mar 26, 2026

Fixes partially https://jira.cfdata.org/browse/DEVX-2380

This PR moves runCommand,quoteShellArgs, installPackages and installWrangler to @cloudflare/cli so that they can be reused from there by C3 and Wrangler autoconfig.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: non-user facing change

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: 7d45faf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

✅ All changesets look good

ask-bonk[bot]

This comment was marked as outdated.

@ask-bonk

This comment was marked as outdated.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 26, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13068

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13068

miniflare

npm i https://pkg.pr.new/miniflare@13068

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13068

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13068

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13068

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13068

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13068

wrangler

npm i https://pkg.pr.new/wrangler@13068

commit: 7d45faf

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2380/1/graduate-cloudflare-cli-utilities branch 2 times, most recently from 9a45459 to 1018684 Compare March 26, 2026 17:57
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review March 26, 2026 19:43
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner March 26, 2026 19:43
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 26, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz dario-piotrowicz removed the request for review from emily-shen March 26, 2026 20:02
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2380/1/graduate-cloudflare-cli-utilities branch from 1018684 to 0acc906 Compare March 27, 2026 12:08
@dario-piotrowicz dario-piotrowicz changed the title Graduate c3-vendor runCommand and quoteShellArgs to @cloudflare/cli Graduate c3-vendor runCommand, quoteShellArgs, installPackages and installWrangler to @cloudflare/cli Mar 27, 2026
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz dario-piotrowicz marked this pull request as draft March 27, 2026 13:48
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2380/1/graduate-cloudflare-cli-utilities branch 4 times, most recently from 524ddce to c3d1767 Compare March 27, 2026 17:34
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review March 27, 2026 17:42
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2380/1/graduate-cloudflare-cli-utilities branch from c3d1767 to 5e4bb36 Compare March 27, 2026 18:02
…and `installWrangler` to `@cloudflare/cli`
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2380/1/graduate-cloudflare-cli-utilities branch from 5e4bb36 to 7d45faf Compare March 27, 2026 18:03
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 30, 2026
@dario-piotrowicz dario-piotrowicz merged commit e631a94 into main Mar 30, 2026
56 of 58 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2380/1/graduate-cloudflare-cli-utilities branch March 30, 2026 11:35
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 30, 2026
NuroDev pushed a commit that referenced this pull request Mar 30, 2026
…and `installWrangler` to `@cloudflare/cli` (#13068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants