Skip to content

Make argsIgnorePattern for no-unused-vars lint rule more strict#13180

Merged
dario-piotrowicz merged 2 commits intomainfrom
dario/better-no-unused-vars-args-ignore-pattern
Apr 2, 2026
Merged

Make argsIgnorePattern for no-unused-vars lint rule more strict#13180
dario-piotrowicz merged 2 commits intomainfrom
dario/better-no-unused-vars-args-ignore-pattern

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 1, 2026

Right now we completely ignore unused vars when they are arguments of functions, I am not sure if this is intentional, wouldn't it be better/cleaner to have lint error on those as we do for other variables? (and ignore args that start with _, allowing us to be explicit on when we do want to have unused arguments)


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactoring

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

⚠️ No Changeset found

Latest commit: 8d38e09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 1, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 1, 2026

@dario-piotrowicz Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review April 1, 2026 09:58
@dario-piotrowicz dario-piotrowicz requested review from a team as code owners April 1, 2026 09:58
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 1, 2026

Codeowners approval required for this PR:

  • @cloudflare/deploy-config
  • @cloudflare/workers-kv
  • ✅ @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/test/plugins/kv/index.spec.ts: [@cloudflare/workers-kv]
  • packages/workers-shared/router-worker/tests/index.test.ts: [@cloudflare/deploy-config]

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 1, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13180

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13180

miniflare

npm i https://pkg.pr.new/miniflare@13180

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13180

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13180

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13180

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13180

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13180

wrangler

npm i https://pkg.pr.new/wrangler@13180

commit: 8d38e09

devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/better-no-unused-vars-args-ignore-pattern branch from 07c52b2 to c23d8db Compare April 1, 2026 10:45
@dario-piotrowicz dario-piotrowicz force-pushed the dario/better-no-unused-vars-args-ignore-pattern branch from c23d8db to 8a019e3 Compare April 1, 2026 15:46
devin-ai-integration[bot]

This comment was marked as resolved.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/better-no-unused-vars-args-ignore-pattern branch from 8a019e3 to bf071ab Compare April 1, 2026 16:57
@dario-piotrowicz dario-piotrowicz force-pushed the dario/better-no-unused-vars-args-ignore-pattern branch from bf071ab to 0a2936a Compare April 2, 2026 09:52
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners Bypass

@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Apr 2, 2026
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2026
@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 8f0c544 Apr 2, 2026
59 of 60 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/better-no-unused-vars-args-ignore-pattern branch April 2, 2026 14:53
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants