Make argsIgnorePattern for no-unused-vars lint rule more strict#13180
Merged
dario-piotrowicz merged 2 commits intomainfrom Apr 2, 2026
Merged
Make argsIgnorePattern for no-unused-vars lint rule more strict#13180dario-piotrowicz merged 2 commits intomainfrom
argsIgnorePattern for no-unused-vars lint rule more strict#13180dario-piotrowicz merged 2 commits intomainfrom
Conversation
|
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@dario-piotrowicz Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
07c52b2 to
c23d8db
Compare
penalosa
approved these changes
Apr 1, 2026
c23d8db to
8a019e3
Compare
8a019e3 to
bf071ab
Compare
bf071ab to
0a2936a
Compare
penalosa
approved these changes
Apr 2, 2026
ascorbic
approved these changes
Apr 2, 2026
workers-devprod
approved these changes
Apr 2, 2026
Contributor
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners Bypass
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we completely ignore unused vars when they are arguments of functions, I am not sure if this is intentional, wouldn't it be better/cleaner to have lint error on those as we do for other variables? (and ignore args that start with
_, allowing us to be explicit on when we do want to have unused arguments)A picture of a cute animal (not mandatory, but encouraged)