Skip to content

Make argsIgnorePattern for no-unused-vars lint rule more strict #13180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dario-piotrowicz merged 2 commits into from
Apr 2, 2026
Merged

Make argsIgnorePattern for no-unused-vars lint rule more strict #13180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a2936a
Make `argsIgnorePattern` for `no-unused-vars` lint rule more strict
dario-piotrowicz Apr 1, 2026
8d38e09
fix lint issue
dario-piotrowicz Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .oxlintrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"no-unused-vars": [
"error",
{
"argsIgnorePattern": ".*",
"argsIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"ignoreRestSiblings": true,
"fix": { "imports": "fix" },
Expand Down
2 changes: 1 addition & 1 deletion packages/miniflare/src/plugins/core/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ export const CORE_PLUGIN: Plugin<
return Object.fromEntries(await Promise.all(bindingEntries));
},
async getServices({
log,
log: _log,
options,
sharedOptions,
workerBindings,
Expand Down
2 changes: 1 addition & 1 deletion packages/miniflare/src/workers/browser-rendering/binding.worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export class BrowserSession extends MiniflareDurableObject<BrowserSessionEnv> {
};

@GET("/v1/devtools/browser/:sessionId")
connect: RouteHandler = async (req) => {
connect: RouteHandler = async (_req) => {
assert(
this.sessionInfo !== undefined,
"sessionInfo must be set before connecting"
Expand Down
2 changes: 1 addition & 1 deletion packages/miniflare/test/plugins/kv/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ test("delete: deletes existing keys", async ({ expect }) => {
await kv.delete("key");
expect(await kv.get("key")).toBe(null);
});
test("delete: does nothing for non-existent keys", async ({ expect }) => {
test("delete: does nothing for non-existent keys", async () => {
const { kv } = ctx;
await kv.delete("key");
});
Expand Down
2 changes: 1 addition & 1 deletion packages/quick-edit-extension/scripts/bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ async function buildMain(flags: BuildFlags = {}) {
{
name: "workers-types",
setup(build) {
build.onResolve({ filter: /^raw:.*/ }, async (args) => {
build.onResolve({ filter: /^raw:.*/ }, async () => {
const result = path.resolve(
"node_modules/@cloudflare/workers-types/experimental/index.d.ts"
);
Expand Down
Loading
Loading