Skip to content

Rename browser-rendering fixture and test file to browser-run#13566

Merged
NuroDev merged 3 commits intocloudflare:mainfrom
jonnyparris:ruskin/rename-browser-run-cleanup
Apr 16, 2026
Merged

Rename browser-rendering fixture and test file to browser-run#13566
NuroDev merged 3 commits intocloudflare:mainfrom
jonnyparris:ruskin/rename-browser-run-cleanup

Conversation

@jonnyparris
Copy link
Copy Markdown
Member

Follow-up cleanup from #13516 per review feedback from @petebacondarwin.

Changes

  • fixtures/browser-rendering/fixtures/browser-run/ (directory + package.json name)
  • packages/wrangler/src/__tests__/browser-rendering.test.tsbrowser-run.test.ts
  • pnpm-lock.yaml updated to match new fixture path

  • Tests
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this is a pure rename of internal fixtures/test files with no logic changes
  • Public documentation
    • Documentation not necessary because: internal file renames only

beep-boop-🤖

Follow-up cleanup from cloudflare#13516 per review feedback from @petebacondarwin:
- fixtures/browser-rendering/ → fixtures/browser-run/
- browser-rendering.test.ts → browser-run.test.ts
- Updated fixture package.json name and pnpm-lock.yaml

beep-boop-🤖
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 16, 2026

⚠️ No Changeset found

Latest commit: b0f47ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 16, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13566

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13566

miniflare

npm i https://pkg.pr.new/miniflare@13566

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13566

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13566

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13566

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13566

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13566

wrangler

npm i https://pkg.pr.new/wrangler@13566

commit: b0f47ba

@jonnyparris jonnyparris marked this pull request as ready for review April 16, 2026 13:25
@workers-devprod workers-devprod requested review from a team and NuroDev and removed request for a team April 16, 2026 13:25
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 16, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@petebacondarwin
Copy link
Copy Markdown
Contributor

I thought from the previous PR description that you explicitly were not going to update directory and file names.
But happy to go with this if you want.

@jonnyparris
Copy link
Copy Markdown
Member Author

Could a maintainer add the no-changeset-required label? This is a test-only rename with no user-facing impact. beep-boop-🤖

Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 16, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 CI workflow still references old fixture directory name, breaking Ubuntu test exclusion (.github/workflows/test-and-check.yml:153)

The CI workflow at .github/workflows/test-and-check.yml:153 uses --filter="!./fixtures/browser-rendering" to exclude the browser fixture tests on Ubuntu runners due to known AppArmor/Puppeteer issues (as noted in the comment on line 152). Since the fixture directory was renamed from fixtures/browser-rendering to fixtures/browser-run, this filter no longer matches anything, meaning the browser tests will now run on Ubuntu CI runners where they are expected to fail.

View 3 additional findings in Devin Review.

Open in Devin Review

The Ubuntu exclusion filter still referenced the old fixtures/browser-rendering
path, which would silently stop matching after the rename and cause browser
tests to run on Ubuntu where they fail due to AppArmor/Puppeteer issues.

beep-boop-🤖
@jonnyparris
Copy link
Copy Markdown
Member Author

I thought from the previous PR description that you explicitly were not going to update directory and file names. But happy to go with this if you want.

yep focus of last PR was just what was customer facing for blog launch yesterday but make sense to clean up the rest now 👍🏾

@NuroDev NuroDev merged commit 0444fdd into cloudflare:main Apr 16, 2026
49 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants