Skip to content

Rename browser-rendering fixture and test file to browser-run #13566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NuroDev merged 3 commits into from
Apr 16, 2026
Merged

Rename browser-rendering fixture and test file to browser-run #13566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a22935
Rename browser-rendering fixture directory and test file to browser-run
jonnyparris Apr 16, 2026
55d4a95
Remove unnecessary changeset — test-only rename, no user-facing impact
jonnyparris Apr 16, 2026
b0f47ba
Fix CI filter for renamed browser-run fixture directory
jonnyparris Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test-and-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ jobs:

- name: Run tests (fixtures)
if: steps.changes.outputs.everything_but_markdown == 'true' && matrix.suite == 'fixtures'
# Browser rendering is disabled on Ubuntu because of https://pptr.dev/troubleshooting#issues-with-apparmor-on-ubuntu
run: pnpm run test:ci --concurrency 1 --log-order=stream --filter="./fixtures/*" ${{ matrix.os == 'ubuntu-latest' && '--filter="!./fixtures/browser-rendering"' || '' }}
# Browser Run fixture is disabled on Ubuntu because of https://pptr.dev/troubleshooting#issues-with-apparmor-on-ubuntu
run: pnpm run test:ci --concurrency 1 --log-order=stream --filter="./fixtures/*" ${{ matrix.os == 'ubuntu-latest' && '--filter="!./fixtures/browser-run"' || '' }}
env:
NODE_OPTIONS: "--max_old_space_size=8192"
WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
Expand Down
2 changes: 1 addition & 1 deletion fixtures/browser-rendering/package.json → fixtures/browser-run/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@fixture/browser-rendering",
"name": "@fixture/browser-run",
"private": true,
"scripts": {
"cf-typegen": "wrangler types",
Expand Down
0 fixtures/browser-rendering/src/index.ts → fixtures/browser-run/src/index.ts
View file
Open in desktop
File renamed without changes.
0 fixtures/browser-rendering/src/playwright.ts → fixtures/browser-run/src/playwright.ts
View file
Open in desktop
File renamed without changes.
0 fixtures/browser-rendering/src/puppeteer.ts → fixtures/browser-run/src/puppeteer.ts
View file
Open in desktop
File renamed without changes.
0 ...ures/browser-rendering/test/index.spec.ts → fixtures/browser-run/test/index.spec.ts
View file
Open in desktop
File renamed without changes.
0 ...ures/browser-rendering/test/tsconfig.json → fixtures/browser-run/test/tsconfig.json
View file
Open in desktop
File renamed without changes.
0 fixtures/browser-rendering/tsconfig.json → fixtures/browser-run/tsconfig.json
View file
Open in desktop
File renamed without changes.
0 fixtures/browser-rendering/vitest.config.mts → fixtures/browser-run/vitest.config.mts
View file
Open in desktop
File renamed without changes.
0 ...owser-rendering/worker-configuration.d.ts → ...res/browser-run/worker-configuration.d.ts
View file
Open in desktop
File renamed without changes.
0 fixtures/browser-rendering/wrangler.jsonc → fixtures/browser-run/wrangler.jsonc
View file
Open in desktop
File renamed without changes.
0 ...r/src/__tests__/browser-rendering.test.ts → ...rangler/src/__tests__/browser-run.test.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading