Skip to content

Hardcode asset worker cohort to 'ent' for latency testing#13855

Merged
WillTaylorDev merged 5 commits into
cloudflare:mainfrom
courtney-sims:csims/hardcode-cohort-ent
May 7, 2026
Merged

Hardcode asset worker cohort to 'ent' for latency testing#13855
WillTaylorDev merged 5 commits into
cloudflare:mainfrom
courtney-sims:csims/hardcode-cohort-ent

Conversation

@courtney-sims
Copy link
Copy Markdown
Contributor

@courtney-sims courtney-sims commented May 7, 2026

Fixes #wc-4889.

Hardcodes the cohort determination temporarily to help narrow down latency issues.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal only

A picture of a cute animal (not mandatory, but encouraged)
PXL_20240505_171719831

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: f75972a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13855

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13855

miniflare

npm i https://pkg.pr.new/miniflare@13855

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13855

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13855

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13855

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13855

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13855

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13855

wrangler

npm i https://pkg.pr.new/wrangler@13855

commit: f75972a

@courtney-sims courtney-sims marked this pull request as ready for review May 7, 2026 16:16
Copy link
Copy Markdown
Contributor

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd probably hard-code both to start with, just so we have the best chance of 100%ing a release with as much of the glue as possible, and then flipping either the cohort loopback back or this back.

But if you want to start with just this, that's up to you :)

@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team May 7, 2026 16:16
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented May 7, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/deploy-config
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@GregBrimble
Copy link
Copy Markdown
Contributor

You might need a changeset too, to actually trigger a release? I can't remember how this CI is set up.

devin-ai-integration[bot]

This comment was marked as resolved.

@courtney-sims courtney-sims marked this pull request as draft May 7, 2026 18:12
@courtney-sims courtney-sims marked this pull request as ready for review May 7, 2026 18:12
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 7, 2026
@WillTaylorDev WillTaylorDev merged commit dba84c2 into cloudflare:main May 7, 2026
54 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 7, 2026
@courtney-sims courtney-sims deleted the csims/hardcode-cohort-ent branch May 7, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants