Skip to content

Hardcode asset worker cohort to 'ent' for latency testing #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WillTaylorDev merged 5 commits into from
May 7, 2026
+16 −6
Merged

Hardcode asset worker cohort to 'ent' for latency testing #13855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7e1883
Hardcode asset worker cohort to 'ent' for latency testing
courtney-sims May 7, 2026
cb92c4c
Merge branch 'main' into csims/hardcode-cohort-ent
courtney-sims May 7, 2026
b39527a
Also disable cohort version routing in getInnerEntrypoint and add cha…
courtney-sims May 7, 2026
da3c3ff
Prefix unused cohort param with underscore to fix lint
courtney-sims May 7, 2026
f75972a
Merge branch 'main' into csims/hardcode-cohort-ent
courtney-sims May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/hardcode-cohort-ent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@cloudflare/workers-shared": patch
---

Temporarily hardcode asset worker cohort to "ent" for latency testing

Disables the `lookupCohort` RPC call and cohort-based version routing in the outer entrypoint while keeping all the glue code (analytics, bindings, types) in place for re-enablement.
15 changes: 9 additions & 6 deletions packages/workers-shared/asset-worker/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,10 +372,12 @@ export default class AssetWorkerOuter<TEnv extends Env = Env>
*/
private async getCohort(): Promise<string | null> {
if (this.resolvedCohort === undefined) {
this.resolvedCohort = await lookupCohort(
this.env,
this.env.CONFIG?.account_id
);
// TODO: Hardcoding temporarily for latency testing.
// this.resolvedCohort = await lookupCohort(
// this.env,
// this.env.CONFIG?.account_id
// );
this.resolvedCohort = "ent";
Comment thread
courtney-sims marked this conversation as resolved.
}
return this.resolvedCohort;
}
Expand All @@ -385,7 +387,7 @@ export default class AssetWorkerOuter<TEnv extends Env = Env>
* When a cohort is provided, the runtime routes the inner entrypoint
* to the version assigned to that cohort in the current deployment.
*/
private getInnerEntrypoint(cohort?: string | null): AssetWorkerMethods {
private getInnerEntrypoint(_cohort?: string | null): AssetWorkerMethods {
const loopbackCtx = this.ctx as AssetWorkerContext;
const entrypoint = loopbackCtx.exports?.AssetWorkerInner;
if (entrypoint === undefined) {
Expand All @@ -397,7 +399,8 @@ export default class AssetWorkerOuter<TEnv extends Env = Env>
}
return entrypoint({
props: { traceContext: this.env.JAEGER.getSpanContext() },
...(cohort ? { version: { cohort } } : {}),
// TODO: Hardcoding temporarily for latency testing.
// ...(cohort ? { version: { cohort } } : {}),
});
}

Expand Down
Loading