Skip to content

feat: add type declaration files if they do not exist in Astro templates#7469

Closed
mohankumarelec wants to merge 1 commit intocloudflare:mainfrom
mohankumarelec:astro-bug-fix
Closed

feat: add type declaration files if they do not exist in Astro templates#7469
mohankumarelec wants to merge 1 commit intocloudflare:mainfrom
mohankumarelec:astro-bug-fix

Conversation

@mohankumarelec
Copy link
Copy Markdown

Fixes #7416
Fixes #6930

Describe your change...

Add type declaration files if they do not exist in Astro templates


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: bug fix
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix

@mohankumarelec mohankumarelec requested a review from a team December 6, 2024 07:43
@mohankumarelec mohankumarelec requested a review from a team as a code owner December 6, 2024 07:43
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 099782c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dario-piotrowicz
Copy link
Copy Markdown
Member

Thank you very much for the PR @mohankumarelec 🙏

I'm very sorry, I didn't see you opening this PR and I've already implemented a solution for this issue in #7497 😓 🙇

Your PR seems to also update the file incorrectly (I don't think it shouldn't just refer to ../.astro/types.d.ts, right @alexanderniebuhr?) and it is not using C3's utilities (but calling existsSync and writeFileSync directly, which is inconsistent with the C3 code)

So I am closing this PR in favour of #7497, sorry 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants