make sure C3 works with the latest astro versions#7497
Conversation
🦋 Changeset detectedLatest commit: 6488dc439e099750badfde3f1d47c6a6ba47c794 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-wrangler-7497You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7497/npm-package-wrangler-7497Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-wrangler-7497 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-create-cloudflare-7497 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-cloudflare-kv-asset-handler-7497npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-miniflare-7497npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-cloudflare-pages-shared-7497npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-cloudflare-vitest-pool-workers-7497npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-cloudflare-workers-editor-shared-7497npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-cloudflare-workers-shared-7497npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12255380940/npm-package-cloudflare-workflows-shared-7497Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
2cf4c69 to
e513b82
Compare
e513b82 to
6488dc4
Compare
There was a problem hiding this comment.
Funnily enough, it looks like this isn't really needed since it looks like the Astro CLI creates a tsconfig.json for you even if you tell it that you're not planning on using TypeScript 🤷
I would still keep this in as I think this is the proper implementation (workaround excluded) and it is more robust (it won't break if the Astro CLI changes the above behavior and stops creating the tsconfig file)
make sure that both the stable and experimental C3 Astro templates work with the latest Astro versions (which no longer include an src/env.d.ts file in their starting templates)
6488dc4 to
b8a15f4
Compare
|
So adding the |
Yes, we've discussed this already, so sorry that we still haven't provided the API for you 🙇 @andyjessop are there any updates / potential planned work on the API? |
Hey @dario-piotrowicz! Thanks for the ping. I've spoken about this internally and I think we can start work on it straightaway. |
|
Sorry to comment without much to add, but is there any way of invoking C3 with this changeset? I'm blocked on creating an Astro app. |
|
I think you want: |
fixes #7416
This PR makes sure that both the stable and experimental C3 Astro templates work with the latest Astro versions (which are currently broken since they no longer include an
src/env.d.tsfile in their starting templates)