vite-plugin: update to use the new `@cloudflare/unenv-preset` by petebacondarwin · Pull Request #7830 · cloudflare/workers-sdk

petebacondarwin · 2025-01-20T19:26:44Z

Fixes #8054

Updates the Vite plugin to use the new Cloudflare unenv preset
Updates the Vite plugin to support Vite 6.1 (fixing the issues with the node-compat)
Refactors the node-compat stuff to isolate it all in a single Vite plugin

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: not related to Wrangler e2e tests
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: refactoring/bug fix

changeset-bot · 2025-01-20T19:26:48Z

🦋 Changeset detected

Latest commit: 6299a9222ecd4bbeaba1ec1c2ca0f7b33247c8fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/vite-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-01-20T19:34:11Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-wrangler-7830

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7830/npm-package-wrangler-7830

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-wrangler-7830 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-workers-bindings-extension-7830 -O ./cloudflare-workers-bindings-extension.0.0.0-vc4fc52576.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc4fc52576.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-create-cloudflare-7830 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-kv-asset-handler-7830

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-miniflare-7830

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-pages-shared-7830

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-unenv-preset-7830

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-vite-plugin-7830

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-vitest-pool-workers-7830

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-workers-editor-shared-7830

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-workers-shared-7830

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13264468734/npm-package-cloudflare-workflows-shared-7830

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.107.3 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20250129.0
`workerd`	1.20250204.0	1.20250204.0
`workerd --version`	1.20250204.0	2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

vicb · 2025-02-10T14:08:10Z

Not sure if this should be "1.1.1" (no ~)? We can relax the range once 2.0 is released

Is it expected that the plugin has no (peer) dep on workerd?

wrangler is in both devDep and peerDep, as is Vite

Wrangler is there twice because the devDep is only for testing (and we use the workspace version); while the peerDep is a range ("wrangler": "^3.101.0") which constrains the minimum version.

Happy to pin this dep to 1.1.1 if that helps.

the cf unenv preset has its own peer dependency on workerd.

Happy to pin this dep to 1.1.1 if that helps

It's more that we do not expect any 1.1.2...

the cf unenv preset has its own peer dependency on workerd.

it's a peer dep so it should be installed somewhere...

It'll be installed as part of Wrangler

vicb

I only took a quick look.

How urgent is this? If this can be put on hold until we release the v2 of the preset, that would be ideal

petebacondarwin · 2025-02-10T14:12:45Z

I only took a quick look.

How urgent is this? If this can be put on hold until we release the v2 of the preset, that would be ideal

The Vite plugin is currently broken with Vite 6.1 and this solves that. If we want to hold off on landing this then I would have to put up a fix for the old unenv usage.

Is there a reason to hold this back? This Vite plugin is, itself, in beta, so it feels like a good place to try out new stuff like the Cloudflare unenv update.

vicb · 2025-02-10T14:24:45Z

Is there a reason to hold this back? This Vite plugin is, itself, in beta, so it feels like a good place to try out new stuff like the Cloudflare unenv update.

I'm asking mostly because I don't have time to do a deep review.
But if everything is still in beta, there should be no problem.

There might be changes to do after #7915 is merged / 2.0 is released

vicb

No time for a deep review right now.
But @petebacondarwin mentioned it fixes issues and the plugin is still in beta.
I can look at it more closely after v2.0 of the preset is released

jamesopstad

Looks good, as far as I understand the new preset. I would prefer the plugins to be defined in the same file though so that they have access to the cloudflare function scope.

jamesopstad

Looks good! I think there's still a bit of an open question about what's correct for preview mode but happy for you to make the decision on this.

…de.js compat module

petebacondarwin force-pushed the pbd/update-vite-plugin-to-use-cloudflare-unenv-preset branch 6 times, most recently from 169c800 to a2cd688 Compare February 10, 2025 13:46

petebacondarwin marked this pull request as ready for review February 10, 2025 13:50

petebacondarwin requested a review from a team as a code owner February 10, 2025 13:50

petebacondarwin requested a review from a team February 10, 2025 13:50

vicb reviewed Feb 10, 2025

View reviewed changes

petebacondarwin force-pushed the pbd/update-vite-plugin-to-use-cloudflare-unenv-preset branch from 85717f6 to 5e2abeb Compare February 10, 2025 14:15

vicb approved these changes Feb 10, 2025

View reviewed changes

jamesopstad reviewed Feb 10, 2025

View reviewed changes

jamesopstad added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Feb 10, 2025

petebacondarwin force-pushed the pbd/update-vite-plugin-to-use-cloudflare-unenv-preset branch from 5e2abeb to 9291388 Compare February 10, 2025 18:56

petebacondarwin requested a review from jamesopstad February 10, 2025 20:52

jamesopstad approved these changes Feb 11, 2025

View reviewed changes

Comment thread packages/vite-plugin-cloudflare/src/index.ts

Comment thread packages/vite-plugin-cloudflare/src/index.ts

petebacondarwin force-pushed the pbd/update-vite-plugin-to-use-cloudflare-unenv-preset branch from e931930 to 6299a92 Compare February 11, 2025 13:34

petebacondarwin added 7 commits February 11, 2025 13:51

vite-plugin: update to use the new @cloudflare/unenv-preset

b6de882

update to use Vite 6.1

8999915

refactor: move nodejs-compat stuff into its own Vite plugin

b1efc5b

add changesets

e577183

pin the cf unenv preset dependency to 1.1.1

b052063

update sub-plugin name

325e39c

throw if we fail to resolve an aliased import

ddc025b

petebacondarwin added 6 commits February 11, 2025 13:51

Update virtual module prefix

4ea2050

fix comment typo

315e15f

Error if there is no alias found for an import marked as a virtual no…

3a2e76b

…de.js compat module

move node.js compat plugin back into index.ts and do some code clean up

1259da5

revert to short-circuiting the config when in preview mode

9e026ef

tweak comment

b46a906

petebacondarwin force-pushed the pbd/update-vite-plugin-to-use-cloudflare-unenv-preset branch from 6299a92 to b46a906 Compare February 11, 2025 13:51

penalosa approved these changes Feb 11, 2025

View reviewed changes

penalosa merged commit 99ba292 into main Feb 11, 2025

penalosa deleted the pbd/update-vite-plugin-to-use-cloudflare-unenv-preset branch February 11, 2025 15:10

workers-devprod mentioned this pull request Feb 11, 2025

Version Packages #8096

Merged

patsaas mentioned this pull request Feb 12, 2025

🐛 BUG: @cloudflare/vite-plugin vite dev errors when nodejs_compat is enabled #8108

Closed

Conversation

petebacondarwin commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vicb Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

vicb Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

vicb Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

vicb left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin commented Feb 10, 2025

Uh oh!

vicb commented Feb 10, 2025

Uh oh!

vicb left a comment

Choose a reason for hiding this comment

Uh oh!

jamesopstad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesopstad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

petebacondarwin commented Jan 20, 2025 •

edited

Loading

changeset-bot Bot commented Jan 20, 2025 •

edited

Loading

github-actions Bot commented Jan 20, 2025 •

edited

Loading

vicb Feb 10, 2025 •

edited

Loading