Conversation
|
|
@vicb Can you rebase? |
I will, probably tomorrow. For now this is only a preview syncing with the next version of unenv edit Jan 28: rebased and tested locally using |
631bbf7 to
ce8b989
Compare
|
Drop timers + rebased |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-wrangler-7915You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7915/npm-package-wrangler-7915Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-wrangler-7915 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-workers-bindings-extension-7915 -O ./cloudflare-workers-bindings-extension.0.0.0-vac7291578.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vac7291578.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-create-cloudflare-7915 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-kv-asset-handler-7915miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-miniflare-7915@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-pages-shared-7915@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-unenv-preset-7915@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-vite-plugin-7915@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-vitest-pool-workers-7915@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-workers-editor-shared-7915@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-workers-shared-7915@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13585800010/npm-package-cloudflare-workflows-shared-7915Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
|
@petebacondarwin I have started to sync with unenv - there are still a few changes to sync. I also have 2 PRs on unenv that are pendings. This PR also needs to be tested with a version of wrangler actually using the preset - currently I hope to be done with that later today so that we can release |
778b8e4 to
fe14753
Compare
|
@petebacondarwin we need to fix The PR should be ready by tomorrow but feel free to take a look before. Thanks! |
8ede4cb to
b557544
Compare
fa6a903 to
40a3a2b
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
Nice work! Got there finally!
As well as updating Wrangler, we'll need to update Vite plugin.
| @@ -64,29 +65,25 @@ export const cloudflare: Preset = { | |||
| ), | |||
There was a problem hiding this comment.
Out of curiosity, why do we create all these identity aliases? It seems a bit pointless?
Shouldn't we only add aliases for things that need to be mapped to polyfills?
(I could understand creating ${p} -> node:${p} perhaps?)
There was a problem hiding this comment.
I have added this comment:
// `nodeCompatModules` are implemented in workerd.
// Create aliases to override polyfills defined in based environments.
Does it help?
|
Is it worth adding a changeset now? |
I'll first merge the PR, test the PR releases and if that looks good we can add a changeset |
There was a problem hiding this comment.
(might be worth to add a test if you can o make sure it will exist in dist -- had a tough time to investigate issue in unenv when we changed bundler)
Sync
@cloudflare/unenv-presetwithunenv@2.0.0-rc.8Changelog:
globalThis.performancein nodejs_compat mode #8111)Notes:
The ESBuild plugin needs to be updated because
polyfillproperty of the presetEnvironmentYou can check the WIP/test-preset branch that includes the updates and test the preset.
I have deliberately not include included a changelog because this package should not be released before 2.0 is ready
This is part 1 of 2 in a stack made with GitButler: