remove setImmediate and clearImmediate from injects#7939
remove setImmediate and clearImmediate from injects#7939petebacondarwin merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 8eb93c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ea6b903 to
8eb93c2
Compare
| "@cloudflare/unenv-preset": patch | ||
| --- | ||
|
|
||
| Remove clearImmediate and setImmediate injects |
There was a problem hiding this comment.
| Remove clearImmediate and setImmediate injects | |
| Remove clearImmediate and setImmediate injects. | |
| These are now available in workerd (as of ???? version) |
There was a problem hiding this comment.
Since: v1.20240815 - cloudflare/workerd@f07cd8e
There was a problem hiding this comment.
v1.20240815
Oh, not so long ago.
Do we want to have an implementation for those function in our preset.
It would be tree shakeable use setTimeout(0), i.e. 1 LOC.
Edit: We actually do not need the injects - set/clearImmediate are gated by nodejs_compat_v2 which is after 2024-08-15 (2024-09-23)
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-wrangler-7939You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7939/npm-package-wrangler-7939Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-wrangler-7939 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-workers-bindings-extension-7939 -O ./cloudflare-workers-bindings-extension.0.0.0-vfddc6e554.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfddc6e554.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-create-cloudflare-7939 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-kv-asset-handler-7939miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-miniflare-7939@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-pages-shared-7939@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-unenv-preset-7939@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-vite-plugin-7939@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-vitest-pool-workers-7939@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-workers-editor-shared-7939@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-workers-shared-7939@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13014041620/npm-package-cloudflare-workflows-shared-7939Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Removes setImmediate and clearImmediate from injects since they're enabled in workerd by default.