fix(wrangler): skip non-successful deployments when tailing Pages logs

[mlafeldt]

Tailing logs of Pages deployments currently fails when a deployment was skipped, e.g. due to build watch paths.

$ wrangler pages deployment tail --project-name myproject
No deployment specified. Using latest deployment for production environment.

✘ [ERROR] A request to the Cloudflare API (/accounts/xxx/pages/projects/myproject/deployments/9dc87402-90c7-4227-b7cf-aa47630e588a/tails) failed.

  The requested Worker version could not be found, please check the ID being passed and try again.
  [code: 8000068]

Such skipped deployments have this latest stage:

latest_stage: { name: 'queued', started_on: null, ended_on: null, status: 'idle' },

(In an ideal world, the status should be skipped and not idle, but that's a different issue.)

To fix this problem, I changed the logic that finds the last deployment to consider successful deployments only.

---

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because:
• Wrangler V3 Backport
  • TODO (before merge)
  • Wrangler PR:
  • Not necessary because:

[changeset-bot]

🦋 Changeset detected

Latest commit: beb6cf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[petebacondarwin]

@mlafeldt - thanks for this PR. Would you mind rebasing and then we can review and merge it.

[mlafeldt]

@petebacondarwin In the meantime, I've figured that wrangler pages deployment tail uses the wrong (or at least suboptimal) API call. It should use canonical_deployment as returned by /accounts/{account_id}/pages/projects/{project_name} to get the most recent deployment. Do you agree? Happy to update the PR.

[petebacondarwin]

Give it a go!

[mlafeldt]

@petebacondarwin Rebased the PR. I ended up not using canonical_deployment because it only seems to exist for production and won't work with --environment preview.

[petebacondarwin]

This looks good but we could do with a test - perhaps in here https://github.com/cloudflare/workers-sdk/blob/6479fc5228d1249e87c7f668e8efbf88ec5a8f5f/packages/wrangler/src/__tests__/pages/pages-deployment-tail.test.ts

[lrapoport-cf]

hi @mlafeldt :) it looks like #9685 addresses the same problem as you are tackling here, but with one additional change to specify latest_stage.name to also be "deploy" to narrow down results to deployments only. as your PR also still needs tests, we will close this PR in favor of #9685. however, we recognize and really appreciate your contribution, so i've connected with @WillTaylorDev and he will add you as a coauthor on #9685 so that you receive proper acknowledgement.

thanks you for your contribution!