Skip to content

[v3] WC-2965 Prevent selecting in-progress deployments when tailing#9685

Merged
petebacondarwin merged 1 commit intov3-maintenancefrom
v3-backport-9684
Jul 7, 2025
Merged

[v3] WC-2965 Prevent selecting in-progress deployments when tailing#9685
petebacondarwin merged 1 commit intov3-maintenancefrom
v3-backport-9684

Conversation

@WillTaylorDev
Copy link
Copy Markdown
Contributor

@WillTaylorDev WillTaylorDev commented Jun 19, 2025

If not provided with a deployment to tail, Wrangler will try to pull the list of deployments and select the most recently created one. However, we do not check whether this deployment has finished. This is causing intermittent errors for users.

Backport for #9684


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: this is the backport!

@WillTaylorDev WillTaylorDev requested review from a team as code owners June 19, 2025 20:17
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: 2b3bdaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jun 19, 2025
@WillTaylorDev WillTaylorDev added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 19, 2025
Comment thread packages/wrangler/src/__tests__/pages/pages-deployment-tail.test.ts Outdated
Comment thread packages/wrangler/src/__tests__/pages/pages-deployment-tail.test.ts Outdated
@lrapoport-cf
Copy link
Copy Markdown
Contributor

@WillTaylorDev as discussed, please include @mlafeldt as co-author :)

@lrapoport-cf
Copy link
Copy Markdown
Contributor

lrapoport-cf commented Jun 26, 2025

@WillTaylorDev this PR looks to be superseded by #9684? if so, can we close this one?

@emily-shen
Copy link
Copy Markdown
Contributor

emily-shen commented Jun 26, 2025

@WillTaylorDev this PR looks to be superseded by #9684? if so, can we close this one?

i think this is the v3 backport - i'll update the title to reflect

@emily-shen emily-shen changed the title WC-2965 Prevent selecting in-progress deployments when tailing [v3] WC-2965 Prevent selecting in-progress deployments when tailing Jun 26, 2025
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 26, 2025
@lrapoport-cf lrapoport-cf added the v3-backport The PR is a v3 backport targetting the v3-maintenance branch label Jun 26, 2025
If not provided with a deployment to tail, Wrangler will try
to pull the list of deployments and select the most recently created
one. However, we do not check whether this deployment has finished.
This is causing intermittent errors for users.

Co-authored-by: Mathias Lafeldt <mathias.lafeldt@gmail.com>
@petebacondarwin petebacondarwin merged commit cbea64b into v3-maintenance Jul 7, 2025
27 of 33 checks passed
@petebacondarwin petebacondarwin deleted the v3-backport-9684 branch July 7, 2025 19:57
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR v3-backport The PR is a v3 backport targetting the v3-maintenance branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants