Skip to content

WC-2965 Prevent selecting in-progress deployments when tailing#9684

Merged
WillTaylorDev merged 2 commits intomainfrom
willtaylor/wc-2965-bugfix-pages-tail
Jun 25, 2025
Merged

WC-2965 Prevent selecting in-progress deployments when tailing#9684
WillTaylorDev merged 2 commits intomainfrom
willtaylor/wc-2965-bugfix-pages-tail

Conversation

@WillTaylorDev
Copy link
Copy Markdown
Contributor

@WillTaylorDev WillTaylorDev commented Jun 19, 2025

If not provided with a deployment to tail, Wrangler will try to pull the list of deployments and select the most recently created one. However, we do not check whether this deployment has finished. This is causing intermittent errors for users.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport

@WillTaylorDev WillTaylorDev requested review from a team as code owners June 19, 2025 20:00
@WillTaylorDev WillTaylorDev added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 19, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: dfa97f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9684

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9684

miniflare

npm i https://pkg.pr.new/miniflare@9684

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9684

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9684

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9684

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9684

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9684

wrangler

npm i https://pkg.pr.new/wrangler@9684

commit: dfa97f7

@github-actions
Copy link
Copy Markdown
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main willtaylor/wc-2965-bugfix-pages-tail might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9684
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2965-bugfix-pages-tail branch from c96c45a to 83c0b44 Compare June 20, 2025 12:48
If not provided with a deployment to tail, Wrangler will try to pull
the list of deployments and select the most recently created one. However,
we do not check whether this deployment has finished. This is causing
intermittent errors for users.

Co-authored-by: Mathias Lafeldt <mathias.lafeldt@gmail.com>
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-2965-bugfix-pages-tail branch from 83c0b44 to 9ab7228 Compare June 23, 2025 13:51
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 25, 2025
@WillTaylorDev WillTaylorDev added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit 94a340e Jun 25, 2025
24 of 28 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/wc-2965-bugfix-pages-tail branch June 25, 2025 13:35
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants